Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Assert enable_extensions: common/BUILD.gn and features/BUILD.gn are marked TODO(crbug.com/731689) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« BUILD.gn ('K') | « apps/BUILD.gn ('k') | chrome/browser/devtools/BUILD.gn » ('j') | chrome/browser/devtools/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 58cab9d178e635b9fc840712f4b2c7617d3b9971..ab8ff9a92b178ae3d90348d53f3cec8bc2c02e2f 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -3700,7 +3700,6 @@ split_static_library("browser") {
]
deps += [
":theme_properties",
- "//apps",
"//chrome/browser/policy:path_parser",
"//chrome/browser/profile_resetter:profile_reset_report_proto",
"//chrome/common/importer:interfaces",
@@ -3710,6 +3709,9 @@ split_static_library("browser") {
"//components/web_modal",
"//net:net_browser_services",
]
+ if (enable_extensions) {
+ deps += [ "//apps" ]
Devlin 2017/06/09 19:11:51 Can we put this in the other enable_extensions blo
hugoh_UTC2 2017/06/12 09:19:08 Done.
+ }
}
if (enable_pepper_cdms) {
« BUILD.gn ('K') | « apps/BUILD.gn ('k') | chrome/browser/devtools/BUILD.gn » ('j') | chrome/browser/devtools/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698