Allow generation of a chromium outdirs when enable_extensions=false

apps/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//extensions/features/features.gni")
 
 assert(!is_android && !is_ios)
 
 static_library("apps") {

[michaelpg, 2017/05/23 16:54:40]

I would rather this assert(enable_extensions) because apps don't make sense
without extensions -- trying to reason about build behavior, target generation,
dependencies for that case is not useful.

[Dirk Pranke, 2017/05/23 20:00:11]

This seems sensible to me.

[hugoh_UTC2, 2017/05/24 13:58:05]

Done. See PS3.

   sources = []
 
   if (enable_extensions) {
     sources += [
       "app_lifetime_monitor.cc",
       "app_lifetime_monitor.h",
       "app_lifetime_monitor_factory.cc",
       "app_lifetime_monitor_factory.h",
       "app_restore_service.cc",
       "app_restore_service.h",
@@ skipping 11 matching lines @@
       "switches.cc",
       "switches.h",
     ]
 
     configs += [ "//build/config/compiler:wexit_time_destructors" ]
 
     deps = [
       "//components/keyed_service/content",
       "//content/public/browser",
       "//content/public/common",
-      "//extensions/browser",
-      "//extensions/common",
-      "//extensions/common/api",
     ]
 
+    if (enable_extensions) {
+      deps += [
+        "//extensions/browser",
+        "//extensions/common",
+        "//extensions/common/api",
+      ]
+    }
+
     if (is_chromeos) {
       deps += [ "//components/user_manager" ]
     }
   }
 
   # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 }
 
 static_library("test_support") {
   testonly = true
   sources = [
     "test/app_window_waiter.cc",
     "test/app_window_waiter.h",
   ]
 
   public_deps = [
     "//content/public/browser",
   ]
 }