Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 290443004: add a GM case to ensure path effect for big filled/stroked text is correctly rendered (Closed)

Created:
6 years, 7 months ago by yunchao
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

add a GM case to ensure path effect for big filled/stroked text and hairline text is correctly rendered. BUG=skia:2555 @reed has landed a patch to add path effect to gm case stroketext. So close this one.

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
A gm/patheffect4bigtext.cpp View 1 chunk +78 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yunchao
6 years, 7 months ago (2014-05-15 09:10:02 UTC) #1
yunchao
On 2014/05/15 09:10:02, Richard Ho wrote: ping...
6 years, 7 months ago (2014-05-20 15:37:49 UTC) #2
reed1
Is this different from "stroketext" gm, that shows a bug when stroking big text using ...
6 years, 7 months ago (2014-05-20 17:27:41 UTC) #3
yunchao
On 2014/05/20 17:27:41, reed1 wrote: > Is this different from "stroketext" gm, that shows a ...
6 years, 7 months ago (2014-05-21 13:10:13 UTC) #4
yunchao
6 years, 7 months ago (2014-05-21 13:26:27 UTC) #5
On 2014/05/21 13:10:13, Richard Ho wrote:
> On 2014/05/20 17:27:41, reed1 wrote:
> > Is this different from "stroketext" gm, that shows a bug when stroking big
> text
> > using drawPosText?
> 
> Yes, they are different. This gm add path effect to big text(thick-stroked,
> hairline stroked, filled), and show another rendering errors exists in
> drawPosText_asPaths. But it is correct in drawText_asPaths. You can see the
> rendering result at skbug.com/2555.

The rendering error showed by this new added GM case and the rendering error in
stroketext are both fixed at https://codereview.chromium.org/284763010/, PTAL.

Powered by Google App Engine
This is Rietveld 408576698