Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/bots/pub.py

Issue 290443002: Experiment with running not running tests concurrently on pub on windows (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/pub.py
===================================================================
--- tools/bots/pub.py (revision 36164)
+++ tools/bots/pub.py (working copy)
@@ -36,7 +36,6 @@
return bot.BuildInfo('none', 'vm', mode, system, checked=True,
builder_tag=locale)
-
def PubSteps(build_info):
with bot.BuildStep('Build package-root'):
args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode,
@@ -47,7 +46,8 @@
common_args = ['--write-test-outcome-log']
if build_info.builder_tag:
common_args.append('--builder-tag=%s' % build_info.builder_tag)
-
+
+
# Pub tests currently have a lot of timeouts when run in debug mode.
# See issue 18479
if build_info.mode == 'release':
@@ -56,7 +56,6 @@
else:
bot.RunTest('pub', build_info,
common_args + ['pkg', 'docs'])
-
if build_info.mode == 'release':
pkgbuild_build_info = bot.BuildInfo('none', 'vm', build_info.mode,
@@ -64,8 +63,14 @@
bot.RunTest('pkgbuild_repo_pkgs', pkgbuild_build_info,
common_args + ['--append_logs', '--use-repository-packages',
'pkgbuild'])
- bot.RunTest('pkgbuild_public_pkgs', pkgbuild_build_info,
- common_args + ['--append_logs', '--use-public-packages', 'pkgbuild'])
+ # We are seeing issues with pub get calls on the windows bots.
+ # Experiment with not running concurrent calls.
+ public_args = (common_args +
+ ['--append_logs', '--use-public-packages', 'pkgbuild'])
+ if build_info.system == 'windows':
+ public_args.append('-j1')
+ bot.RunTest('pkgbuild_public_pkgs', pkgbuild_build_info, public_args)
+
if __name__ == '__main__':
bot.RunBot(PubConfig, PubSteps)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698