Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 290433003: Revert of Add a whole-app-list unit test. (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Revert of Add a whole-app-list unit test. (https://codereview.chromium.org/210083009/) Reason for revert: Despite all the green, and earlier full compile on the same bot, now fails compile on Linux Builder. ../../ui/app_list/views/app_list_view_unittest.cc:239:8:error: 'host' was not declared in this scope link: http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/31637 Original issue's description: > Add a whole-app-list unit test. > > This establishes a test harness for doing tests that touch on multiple > parts of the app launcher UI, or that need coverage for the various app > launcher configurations: Ash or Desktop; regular or experimental > "landscape" mode. > > It currently just tests displaying and closing the app launcher in its > default state with a flat (no folders), 2- or 3-page model. > > BUG=169114 > TEST=Added unit tests AppListViewTest{Aura,Desktop}.* > > Previously committed: http://crrev.com/260762 http://crrev.com/260803 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270615 TBR=tapted@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -279 lines) Patch
M chrome/browser/ui/views/app_list/win/app_list_service_win.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 2 chunks +1 line, -7 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view.h View 3 chunks +1 line, -5 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 3 chunks +7 lines, -5 lines 0 comments Download
D ui/app_list/views/app_list_view_unittest.cc View 1 chunk +0 lines, -258 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tapted
Created Revert of Add a whole-app-list unit test.
6 years, 7 months ago (2014-05-15 07:29:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/290433003/1
6 years, 7 months ago (2014-05-15 07:30:54 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 07:30:55 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-15 07:30:55 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 7 months ago (2014-05-15 07:32:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/290433003/1
6 years, 7 months ago (2014-05-15 07:33:23 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 07:35:05 UTC) #7
Message was sent while issue was closed.
Change committed as 270619

Powered by Google App Engine
This is Rietveld 408576698