Issue 2904313002: Revert "Revert "Revert "Revert "Refactor test option parsing code.""""

Issue 2904313002: Revert "Revert "Revert "Revert "Refactor test option parsing code."""" (Closed)

Created:
3 years, 6 months ago by Bob Nystrom

Modified:
3 years, 6 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Revert "Revert "Revert "Refactor test option parsing code."""" This reverts commit 02547656ccb1b9b5e349ad0ac81459cb725cb125. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/c296f75d10f68fd484dd244dd205360ac8f353d7

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+945 lines, -1054 lines)			Patch
M	runtime/tests/vm/vm.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	samples/samples.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/standalone/io/skipping_dart2js_compilations_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/io/test_runner_test.dart	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	tools/testing/dart/co19_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/compiler_configuration.dart	View		12 chunks	+14 lines, -15 lines	0 comments	Download
M	tools/testing/dart/main.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A	tools/testing/dart/options.dart	View		1 chunk	+916 lines, -0 lines	0 comments	Download
M	tools/testing/dart/package_testing_support.dart	View		1 chunk	+4 lines, -6 lines	0 comments	Download
D	tools/testing/dart/test_options.dart	View		1 chunk	+0 lines, -1012 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		2 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

3 years, 6 months ago (2017-05-26 22:04:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:30001) manually as
c296f75d10f68fd484dd244dd205360ac8f353d7 (presubmit successful).