third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp - Issue 2904263002: [Media Controls] Tests for rotate-to-fullscreen meets orientation lock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp

Issue 2904263002: [Media Controls] Tests for rotate-to-fullscreen meets orientation lock (Closed)

Patch Set: Address Tim's nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.h ('K') | « third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp b/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp

index c727e7962728870d41e8c6ac3a269926b5cc1fd5..fbd3b6e791df811dd8ff956b66cfa6517c013cd6 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp

@@ -602,8 +602,8 @@ TEST_F(MediaControlsRotateToFullscreenDelegateTest,

EXPECT_TRUE(GetVideo().paused());

EXPECT_FALSE(ObservedVisibility());

- // Rotate screen to portrait. This relies on the screen orientation no longer

- // being locked by MediaControlsOrientationLockDelegate.

+ // Rotate screen to portrait. This relies on the screen orientation not being

+ // locked by MediaControlsOrientationLockDelegate (which has its own tests).

RotateTo(kWebScreenOrientationPortraitPrimary);

// Should exit fullscreen.

@@ -632,8 +632,8 @@ TEST_F(MediaControlsRotateToFullscreenDelegateTest,