Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: chrome/browser/chromeos/printing/printer_discoverer.h

Issue 2904243003: Add Printing.CUPS.PrintersDiscovered to our metrics. (Closed)
Patch Set: small Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/printing/printer_discoverer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/printing/printer_discoverer.h
diff --git a/chrome/browser/chromeos/printing/printer_discoverer.h b/chrome/browser/chromeos/printing/printer_discoverer.h
index 20fd8bc9b5bf9096e3489c249a4e506dad41f9df..71af882e562968eecaaf2da9c854c277748c5a87 100644
--- a/chrome/browser/chromeos/printing/printer_discoverer.h
+++ b/chrome/browser/chromeos/printing/printer_discoverer.h
@@ -24,20 +24,18 @@ class CHROMEOS_EXPORT PrinterDiscoverer {
public:
virtual ~Observer() = default;
- // Called when we are done with the initial scan for printers. We may
- // still call OnPrintersFound if the set of available printers
- // changes, but the user can conclude that if a printer is currently
- // available and not in the list, we're not still looking for it.
- virtual void OnDiscoveryInitialScanDone() = 0;
-
// Called with a collection of printers as they are discovered. On each
// call |printers| is the full set of known printers; it is not
- // incremental; printers may be added or removed.
+ // incremental; printers may be added or removed. |scan_done| is true after
+ // the initial scan has been completed. Observers will not receive
Carlson 2017/05/26 20:10:20 This comment is a little imprecise, as we may call
skau 2017/05/26 20:23:52 Done.
+ // notifications after scan completion unless a new printer is added to the
+ // environment.
//
// Observers will get an OnPrintersFound callback after registration
// with the existing list of printers (which may be empty) and will get
// additional calls whenever the set of printers changes.
- virtual void OnPrintersFound(const std::vector<Printer>& printers) = 0;
+ virtual void OnPrintersFound(bool scan_done,
+ const std::vector<Printer>& printers) = 0;
};
// Static factory
« no previous file with comments | « no previous file | chrome/browser/chromeos/printing/printer_discoverer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698