Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 290423002: Added HD version of capslock indicator for login screen. (Closed)

Created:
6 years, 7 months ago by dzhioev (left Google)
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Added HD version of capslock indicator for login screen. BUG=316551 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271678

Patch Set 1 #

Patch Set 2 : Merge problems fixed. #

Patch Set 3 : Retry to upload. #

Patch Set 4 : Retry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A + chrome/app/theme/default_100_percent/cros/login_password_capslock.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_100_percent/login_password_capslock.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/cros/login_password_capslock.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
dzhioev (left Google)
Hi, please review. I've applied sanitize-png-files.sh to newly added PNG.
6 years, 7 months ago (2014-05-19 13:41:59 UTC) #1
oshima
lgtm with a note: On 2014/05/19 13:41:59, dzhioev wrote: > Hi, please review. > > ...
6 years, 7 months ago (2014-05-19 18:59:34 UTC) #2
dzhioev (left Google)
On 2014/05/19 18:59:34, oshima wrote: > lgtm with a note: > > On 2014/05/19 13:41:59, ...
6 years, 7 months ago (2014-05-19 20:38:46 UTC) #3
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 7 months ago (2014-05-19 20:38:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/290423002/20001
6 years, 7 months ago (2014-05-19 20:41:47 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 00:06:12 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 00:10:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68520)
6 years, 7 months ago (2014-05-20 00:10:29 UTC) #8
dzhioev (left Google)
6 years, 7 months ago (2014-05-20 17:22:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r271678 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698