Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: pkg/kernel/test/treeshaker_dump.dart

Issue 2904203003: Don't recreate CoreTypes in transformers. Pass it in. (Closed)
Patch Set: Don't create CoreTypes in createOutlines() on InputError. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/test/treeshaker_check.dart ('k') | pkg/kernel/test/treeshaker_membench.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/test/treeshaker_dump.dart
diff --git a/pkg/kernel/test/treeshaker_dump.dart b/pkg/kernel/test/treeshaker_dump.dart
index 0a380d1d44b3d073cba35f65ee1b4968df65625e..0f8f22b983201901aeb145cfdc66d84355f17df5 100644
--- a/pkg/kernel/test/treeshaker_dump.dart
+++ b/pkg/kernel/test/treeshaker_dump.dart
@@ -4,6 +4,7 @@
library kernel.treeshaker_dump;
import 'dart:io';
+import 'package:kernel/core_types.dart';
import 'package:kernel/kernel.dart';
import 'package:kernel/transformations/treeshaker.dart';
import 'package:args/args.dart';
@@ -64,7 +65,8 @@ main(List<String> args) {
bool strong = options['strong'];
Program program = loadProgramFromBinary(filename);
- TreeShaker shaker = new TreeShaker(program, strongMode: strong);
+ CoreTypes coreTypes = new CoreTypes(program);
+ TreeShaker shaker = new TreeShaker(coreTypes, program, strongMode: strong);
int totalClasses = 0;
int totalInstantiationCandidates = 0;
int totalMembers = 0;
@@ -127,7 +129,7 @@ main(List<String> args) {
StringBuffer before = new StringBuffer();
new Printer(before, syntheticNames: names).writeProgramFile(program);
new File(beforeFile).writeAsStringSync('$before');
- new TreeShaker(program, strongMode: strong).transform(program);
+ new TreeShaker(coreTypes, program, strongMode: strong).transform(program);
StringBuffer after = new StringBuffer();
new Printer(after, syntheticNames: names).writeProgramFile(program);
new File(afterFile).writeAsStringSync('$after');
« no previous file with comments | « pkg/kernel/test/treeshaker_check.dart ('k') | pkg/kernel/test/treeshaker_membench.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698