Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: pkg/kernel/test/reify/suite.dart

Issue 2904203003: Don't recreate CoreTypes in transformers. Pass it in. (Closed)
Patch Set: Don't create CoreTypes in createOutlines() on InputError. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/test/closures/suite.dart ('k') | pkg/kernel/test/treeshaker_bench.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/test/reify/suite.dart
diff --git a/pkg/kernel/test/reify/suite.dart b/pkg/kernel/test/reify/suite.dart
index 995e6d80d25f7415cfc87984d30e384566f31cb7..3bfe378a33e464720cbdd6f95c9e80bcbe792cb5 100644
--- a/pkg/kernel/test/reify/suite.dart
+++ b/pkg/kernel/test/reify/suite.dart
@@ -13,6 +13,8 @@ import 'package:analyzer/src/generated/sdk.dart' show DartSdk;
import 'package:analyzer/src/kernel/loader.dart'
show DartLoader, DartOptions, createDartSdk;
+import 'package:kernel/core_types.dart' show CoreTypes;
+
import 'package:kernel/target/targets.dart' show Target, TargetFlags, getTarget;
import 'package:kernel/target/vmcc.dart' show VmClosureConvertedTarget;
@@ -152,7 +154,7 @@ class NotReifiedTarget extends VmClosureConvertedTarget {
// it just deletes everything from those libraries, because they aren't
// used in the program being transform prior to the transformation.
@override
- void performTreeShaking(Program program) {}
+ void performTreeShaking(CoreTypes coreTypes, Program program) {}
// Erasure needs to be disabled, because it removes the necessary information
// about type arguments for generic methods.
@@ -191,9 +193,10 @@ class NotReifiedKernel extends Step<TestDescription, Program, TestContext> {
for (var error in loader.errors) {
return fail(program, "$error");
}
+ var coreTypes = new CoreTypes(program);
target
- ..performModularTransformations(program)
- ..performGlobalTransformations(program);
+ ..performModularTransformations(coreTypes, program)
+ ..performGlobalTransformations(coreTypes, program);
return pass(program);
} catch (e, s) {
return crash(e, s);
@@ -208,7 +211,8 @@ class GenericTypesReification extends Step<Program, Program, TestContext> {
Future<Result<Program>> run(Program program, TestContext testContext) async {
try {
- program = generic_types_reification.transformProgram(program);
+ CoreTypes coreTypes = new CoreTypes(program);
+ program = generic_types_reification.transformProgram(coreTypes, program);
return pass(program);
} catch (e, s) {
return crash(e, s);
« no previous file with comments | « pkg/kernel/test/closures/suite.dart ('k') | pkg/kernel/test/treeshaker_bench.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698