Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: pkg/kernel/lib/transformations/treeshaker.dart

Issue 2904203003: Don't recreate CoreTypes in transformers. Pass it in. (Closed)
Patch Set: Don't create CoreTypes in createOutlines() on InputError. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/transformations/reify/reify_transformer.dart ('k') | pkg/kernel/test/baseline_tester.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/transformations/treeshaker.dart
diff --git a/pkg/kernel/lib/transformations/treeshaker.dart b/pkg/kernel/lib/transformations/treeshaker.dart
index 13f41b23326f498fdf5e817424d62c4b5721d277..102ec75a72043972efe50b7bab1cb7d3f754a606 100644
--- a/pkg/kernel/lib/transformations/treeshaker.dart
+++ b/pkg/kernel/lib/transformations/treeshaker.dart
@@ -10,8 +10,10 @@ import '../core_types.dart';
import '../type_environment.dart';
import '../library_index.dart';
-Program transformProgram(Program program, {List<ProgramRoot> programRoots}) {
- new TreeShaker(program, programRoots: programRoots).transform(program);
+Program transformProgram(CoreTypes coreTypes, Program program,
+ {List<ProgramRoot> programRoots}) {
+ new TreeShaker(coreTypes, program, programRoots: programRoots)
+ .transform(program);
return program;
}
@@ -167,13 +169,12 @@ class TreeShaker {
/// the mirrors library.
bool get forceShaking => programRoots != null && programRoots.isNotEmpty;
- TreeShaker(Program program,
+ TreeShaker(CoreTypes coreTypes, Program program,
{ClassHierarchy hierarchy,
- CoreTypes coreTypes,
bool strongMode: false,
List<ProgramRoot> programRoots})
: this._internal(program, hierarchy ?? new ClassHierarchy(program),
- coreTypes ?? new CoreTypes(program), strongMode, programRoots);
+ coreTypes, strongMode, programRoots);
bool isMemberBodyUsed(Member member) {
return _usedMembers.containsKey(member);
« no previous file with comments | « pkg/kernel/lib/transformations/reify/reify_transformer.dart ('k') | pkg/kernel/test/baseline_tester.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698