Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: pkg/kernel/lib/target/targets.dart

Issue 2904203003: Don't recreate CoreTypes in transformers. Pass it in. (Closed)
Patch Set: Don't create CoreTypes in createOutlines() on InputError. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/target/flutter.dart ('k') | pkg/kernel/lib/target/vm.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/target/targets.dart
diff --git a/pkg/kernel/lib/target/targets.dart b/pkg/kernel/lib/target/targets.dart
index 2b1f49194513aaa26822f39588b9b447b1a48813..0743b6716185611ca19e60f73c8627896956b09c 100644
--- a/pkg/kernel/lib/target/targets.dart
+++ b/pkg/kernel/lib/target/targets.dart
@@ -71,14 +71,14 @@ abstract class Target {
///
/// These transformations should not be whole-program transformations. They
/// should expect that the program will contain external libraries.
- void performModularTransformations(Program program);
+ void performModularTransformations(CoreTypes coreTypes, Program program);
/// Perform target-specific whole-program transformations.
///
/// These transformations should be optimizations and not required for
/// correctness. Everything should work if a simple and fast linker chooses
/// not to apply these transformations.
- void performGlobalTransformations(Program program);
+ void performGlobalTransformations(CoreTypes coreTypes, Program program);
/// Builds an expression that instantiates an [Invocation] that can be passed
/// to [noSuchMethod].
@@ -96,8 +96,8 @@ class NoneTarget extends Target {
bool get strongMode => flags.strongMode;
String get name => 'none';
List<String> get extraRequiredLibraries => <String>[];
- void performModularTransformations(Program program) {}
- void performGlobalTransformations(Program program) {}
+ void performModularTransformations(CoreTypes coreTypes, Program program) {}
+ void performGlobalTransformations(CoreTypes coreTypes, Program program) {}
@override
Expression instantiateInvocation(Member target, Expression receiver,
« no previous file with comments | « pkg/kernel/lib/target/flutter.dart ('k') | pkg/kernel/lib/target/vm.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698