Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: pkg/analyzer/lib/src/fasta/analyzer_loader.dart

Issue 2904203003: Don't recreate CoreTypes in transformers. Pass it in. (Closed)
Patch Set: Don't create CoreTypes in createOutlines() on InputError. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/fasta.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/fasta/analyzer_loader.dart
diff --git a/pkg/analyzer/lib/src/fasta/analyzer_loader.dart b/pkg/analyzer/lib/src/fasta/analyzer_loader.dart
index 49f754364bb93e9fc3792a3a16c6cb146ec79970..f7878293d8996b0059aaf1920beb872fa7a453bd 100644
--- a/pkg/analyzer/lib/src/fasta/analyzer_loader.dart
+++ b/pkg/analyzer/lib/src/fasta/analyzer_loader.dart
@@ -22,6 +22,8 @@ import 'package:analyzer/src/fasta/element_store.dart' show ElementStore;
import 'analyzer_diet_listener.dart' show AnalyzerDietListener;
+import 'package:kernel/core_types.dart' show CoreTypes;
+
class AnalyzerLoader<L> extends SourceLoader<L> {
ElementStore elementStore;
@@ -32,6 +34,8 @@ class AnalyzerLoader<L> extends SourceLoader<L> {
void computeHierarchy(Program program) {
elementStore = new ElementStore(coreLibrary, builders);
ticker.logMs("Built analyzer element model.");
+ coreTypes = new CoreTypes(program);
+ ticker.logMs("Computed core types");
}
@override
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/fasta.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698