Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2904133002: Fix type inference of redirecting factory constructor invocations. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix type inference of redirecting factory constructor invocations. Their types should be inferred based on the initial target of the invocation, not the redirected target. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f60bad7fbca6912cf2f4f449158e50a302688540

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-25 22:03:31 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-25 23:15:28 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-26 00:19:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f60bad7fbca6912cf2f4f449158e50a302688540 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698