|
|
Created:
6 years, 7 months ago by suyash Modified:
6 years, 6 months ago CC:
esprehn, cc-bugs_chromium.org, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionModifying the RenderingStats object names to be more thread specific
There was a TODO in cc/debug/rendering_stats_instrumentation.h for
renaming the RenderingStats objects in order to depict the thread
for which they are.
Patch for doing the same.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276015
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 24 (0 generated)
PTAL Thanks :)
On 2014/05/19 15:01:17, suyash wrote: > PTAL Thanks :) Thank you! LGTM. Please wait until https://codereview.chromium.org/289163004/ has landed and rebase on top of it.
On 2014/05/19 22:01:51, ernstm wrote: > On 2014/05/19 15:01:17, suyash wrote: > > PTAL Thanks :) > > Thank you! LGTM. Please wait until https://codereview.chromium.org/289163004/ > has landed and rebase on top of it. Thanks for the review :) Will do the rebase once https://codereview.chromium.org/289163004/ gets landed
The CQ bit was checked by suyash.s@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/290413003/20001
@enne I am getting a chromium presubmit issue : it requires a review from the owner of the files concerned. Please take a look. Thanls :)
Can you format your patch description to wrap at 72 columns maximum?
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was checked by suyash.s@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/290413003/20001
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
Thanks! I have made the required change in the patch description.
@enne Ping! Kindly review the change made as you suggested.
gentle ping!
LGTM
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/290413003/20001
Message was sent while issue was closed.
Change committed as 276015
Message was sent while issue was closed.
On 2014/06/10 14:14:56, danakj wrote: > LGTM thanks! :) |