Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 290413003: Modifying the RenderingStats object names to be thread specific (Closed)

Created:
6 years, 7 months ago by suyash
Modified:
6 years, 6 months ago
CC:
esprehn, cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Modifying the RenderingStats object names to be more thread specific There was a TODO in cc/debug/rendering_stats_instrumentation.h for renaming the RenderingStats objects in order to depict the thread for which they are. Patch for doing the same. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276015

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M cc/debug/rendering_stats_instrumentation.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M cc/debug/rendering_stats_instrumentation.cc View 1 8 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
suyash
PTAL Thanks :)
6 years, 7 months ago (2014-05-19 15:01:17 UTC) #1
ernstm
On 2014/05/19 15:01:17, suyash wrote: > PTAL Thanks :) Thank you! LGTM. Please wait until ...
6 years, 7 months ago (2014-05-19 22:01:51 UTC) #2
suyash
On 2014/05/19 22:01:51, ernstm wrote: > On 2014/05/19 15:01:17, suyash wrote: > > PTAL Thanks ...
6 years, 7 months ago (2014-05-20 05:07:41 UTC) #3
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 7 months ago (2014-05-21 06:56:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/290413003/20001
6 years, 7 months ago (2014-05-21 06:58:46 UTC) #5
suyash
@enne I am getting a chromium presubmit issue : it requires a review from the ...
6 years, 7 months ago (2014-05-21 07:47:14 UTC) #6
enne (OOO)
Can you format your patch description to wrap at 72 columns maximum?
6 years, 7 months ago (2014-05-21 16:48:02 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 21:11:46 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 21:16:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68997)
6 years, 7 months ago (2014-05-21 21:16:24 UTC) #10
suyash
The CQ bit was checked by suyash.s@samsung.com
6 years, 7 months ago (2014-05-22 06:55:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/290413003/20001
6 years, 7 months ago (2014-05-22 06:56:58 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 07:05:39 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 07:11:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69124)
6 years, 7 months ago (2014-05-22 07:11:45 UTC) #15
suyash
6 years, 7 months ago (2014-05-22 07:13:11 UTC) #16
suyash
Thanks! I have made the required change in the patch description.
6 years, 7 months ago (2014-05-22 07:14:08 UTC) #17
suyash
@enne Ping! Kindly review the change made as you suggested.
6 years, 7 months ago (2014-05-26 05:06:42 UTC) #18
suyash
gentle ping!
6 years, 6 months ago (2014-06-10 05:07:38 UTC) #19
danakj
LGTM
6 years, 6 months ago (2014-06-10 14:14:56 UTC) #20
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 6 months ago (2014-06-10 14:15:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/suyash.s@samsung.com/290413003/20001
6 years, 6 months ago (2014-06-10 14:16:14 UTC) #22
commit-bot: I haz the power
Change committed as 276015
6 years, 6 months ago (2014-06-10 14:25:44 UTC) #23
suyash
6 years, 6 months ago (2014-06-11 05:18:35 UTC) #24
Message was sent while issue was closed.
On 2014/06/10 14:14:56, danakj wrote:
> LGTM

thanks! :)

Powered by Google App Engine
This is Rietveld 408576698