Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 290413002: Fix browser test to work with dynamic CLD (Closed)

Created:
6 years, 7 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 7 months ago
Reviewers:
dconnelly
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@cld_browsertest
Visibility:
Public.

Description

Fix browser test to work with dynamic CLD BUG=367239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271811

Patch Set 1 #

Patch Set 2 : Add call to Init() to workaround gtest macro issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/policy/policy_browsertest.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Andrew Hayden (chromium.org)
Dear owner: NB: This change depends upon https://codereview.chromium.org/285293004/. We are making it possible for the ...
6 years, 7 months ago (2014-05-19 12:55:59 UTC) #1
dconnelly
LGTM
6 years, 7 months ago (2014-05-19 16:26:34 UTC) #2
Andrew Hayden (chromium.org)
Thanks. I had to make an additional one-line change to deal with gtest macro issues ...
6 years, 7 months ago (2014-05-19 17:46:44 UTC) #3
dconnelly
On 2014/05/19 17:46:44, Andrew Hayden wrote: > Thanks. I had to make an additional one-line ...
6 years, 7 months ago (2014-05-20 07:48:18 UTC) #4
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 7 months ago (2014-05-20 18:43:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/290413002/20001
6 years, 7 months ago (2014-05-20 18:44:36 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 02:08:32 UTC) #7
Message was sent while issue was closed.
Change committed as 271811

Powered by Google App Engine
This is Rietveld 408576698