third_party/WebKit/Source/core/editing/markers/DocumentMarker.h - Issue 2904093002: [DMC #18] Eliminate DocumentMarkerTextMatch (subclass of DocumentMarkerDetails)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

Issue 2904093002: [DMC #18] Eliminate DocumentMarkerTextMatch (subclass of DocumentMarkerDetails) (Closed)

Patch Set: Add DCHECKs, more nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

index 2a1dd7d1fbfcf2cbb079740ce22c2f5e14024b02..401bec6f8dea35c9e839689901e625c21d52cc67 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

@@ -174,7 +174,7 @@ class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {

DECLARE_TRACE();

protected:

- DocumentMarker(unsigned start_offset, unsigned end_offset, MatchStatus);

+ DocumentMarker(MarkerType, unsigned start_offset, unsigned end_offset);

private:

MarkerType type_;

yosin_UTC9 2017/05/31 07:06:54 nit: s/MarkerType/const MarkerType/

@@ -197,7 +197,6 @@ class DocumentMarkerDetails

DocumentMarkerDetails() {}

virtual ~DocumentMarkerDetails();

virtual bool IsDescription() const { return false; }

- virtual bool IsTextMatch() const { return false; }

virtual bool IsComposition() const { return false; }

DEFINE_INLINE_VIRTUAL_TRACE() {}

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp » ('j') | no next file with comments »