Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h

Issue 2904093002: [DMC #18] Eliminate DocumentMarkerTextMatch (subclass of DocumentMarkerDetails) (Closed)
Patch Set: Add const, rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
index 2a1dd7d1fbfcf2cbb079740ce22c2f5e14024b02..97a11558f19c0dfed073cd69044bd1794c3f0535 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarker.h
@@ -174,10 +174,10 @@ class CORE_EXPORT DocumentMarker : public GarbageCollected<DocumentMarker> {
DECLARE_TRACE();
protected:
- DocumentMarker(unsigned start_offset, unsigned end_offset, MatchStatus);
+ DocumentMarker(MarkerType, unsigned start_offset, unsigned end_offset);
private:
- MarkerType type_;
+ const MarkerType type_;
unsigned start_offset_;
unsigned end_offset_;
Member<DocumentMarkerDetails> details_;
@@ -197,7 +197,6 @@ class DocumentMarkerDetails
DocumentMarkerDetails() {}
virtual ~DocumentMarkerDetails();
virtual bool IsDescription() const { return false; }
- virtual bool IsTextMatch() const { return false; }
virtual bool IsComposition() const { return false; }
DEFINE_INLINE_VIRTUAL_TRACE() {}

Powered by Google App Engine
This is Rietveld 408576698