ios/showcase/tab_grid/sc_tab_grid_coordinator.mm - Issue 2904053002: [ios] Active web state observer in tab collection.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/showcase/tab_grid/sc_tab_grid_coordinator.mm

Issue 2904053002: [ios] Active web state observer in tab collection. (Closed)

Patch Set: Address comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm ('K') | « ios/clean/chrome/browser/ui/tab_strip/tab_strip_coordinator.mm ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "ios/showcase/tab_grid/sc_tab_grid_coordinator.h"	5 #import "ios/showcase/tab_grid/sc_tab_grid_coordinator.h"

6	6

7 #import "base/format_macros.h"	7 #import "base/format_macros.h"

8 #import "ios/clean/chrome/browser/ui/commands/settings_commands.h"	8 #import "ios/clean/chrome/browser/ui/commands/settings_commands.h"

9 #import "ios/clean/chrome/browser/ui/commands/tab_grid_commands.h"	9 #import "ios/clean/chrome/browser/ui/commands/tab_grid_commands.h"

10 #import "ios/clean/chrome/browser/ui/commands/tools_menu_commands.h"	10 #import "ios/clean/chrome/browser/ui/commands/tools_menu_commands.h"

(...skipping 24 matching lines...) Expand all Loading...
35 self.alerter.baseViewController = self.baseViewController;	35 self.alerter.baseViewController = self.baseViewController;

36	36

37 self.viewController = [[TabGridViewController alloc] init];	37 self.viewController = [[TabGridViewController alloc] init];

38 self.viewController.title = @"Tab Grid";	38 self.viewController.title = @"Tab Grid";

39 self.viewController.dispatcher =	39 self.viewController.dispatcher =

40 static_cast<id<SettingsCommands, TabGridCommands, ToolsMenuCommands>>(	40 static_cast<id<SettingsCommands, TabGridCommands, ToolsMenuCommands>>(

41 self.alerter);	41 self.alerter);

42	42

43 TabCollectionItem* item0 = [[TabCollectionItem alloc] init];	43 TabCollectionItem* item0 = [[TabCollectionItem alloc] init];

44 item0.title = @"Tab 0";	44 item0.title = @"Tab 0";

45 [self.viewController populateItems:@[ item0 ]];	45 [self.viewController populateItems:@[ item0 ] selectedIndex:0];

46	46

47 [self.baseViewController setHidesBarsOnSwipe:YES];	47 [self.baseViewController setHidesBarsOnSwipe:YES];

48 [self.baseViewController pushViewController:self.viewController animated:YES];	48 [self.baseViewController pushViewController:self.viewController animated:YES];

49 }	49 }

50	50

51 @end	51 @end

OLD	NEW