Adding JNIAdditionalImport annotation.

Adding JNIAdditionalImport annotation.

The current JNI generator does not support using an inner class of an
object that is in the same package as the class being processed. This CL
add a new annotation to handle this case.

R=bulach@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271376

[bulach, 2014-05-19 11:54:58]

lgtm, thanks! few suggestions below.

https://codereview.chromium.org/290403002/diff/1/base/android/java/src/org/ch...
File base/android/java/src/org/chromium/base/JNIAdditionalImport.java (right):

https://codereview.chromium.org/290403002/diff/1/base/android/java/src/org/ch...
base/android/java/src/org/chromium/base/JNIAdditionalImport.java:13: *
@JNIAdditionalImport is used by the JNI generator to qualify classes used on
method called by the
nit: not just @CalledByNative, but I suppose also for native methods, right?
in that case, perhaps something like:
...to qualify inner types used on JNI methods.
Must be used when an inner class is used from a class within the same package.
Example:
@JNIAdditionImport(Foo.class)
public class Bar {
  @CalledByNative
  static void doSomethingWithInner(Foo.Inner inner) {...}
}

Notes:
1) Foo must be in the same package as Bar.
2) For classes in different packages, they should be imported as:
import other.package.Foo;
and this annotation should not be used.

https://codereview.chromium.org/290403002/diff/1/base/android/jni_generator/j...
File base/android/jni_generator/jni_generator_tests.py (right):

https://codereview.chromium.org/290403002/diff/1/base/android/jni_generator/j...
base/android/jni_generator/jni_generator_tests.py:1041: 
nit: just for documentation, could do with the class declaration, and also a
"native" method:

public class Foo {
@CalledByNative
private static void calledByNative(Bar.Callback callback) {
}
....
....
private static native void nativeDoSomething(Bar.Callback callback)
}

[qsr, 2014-05-19 12:07:46]

https://codereview.chromium.org/290403002/diff/1/base/android/java/src/org/ch...
File base/android/java/src/org/chromium/base/JNIAdditionalImport.java (right):

https://codereview.chromium.org/290403002/diff/1/base/android/java/src/org/ch...
base/android/java/src/org/chromium/base/JNIAdditionalImport.java:13: *
@JNIAdditionalImport is used by the JNI generator to qualify classes used on
method called by the
On 2014/05/19 11:54:59, bulach wrote:
> nit: not just @CalledByNative, but I suppose also for native methods, right?
> in that case, perhaps something like:
> ...to qualify inner types used on JNI methods.
> Must be used when an inner class is used from a class within the same package.
> Example:
> @JNIAdditionImport(Foo.class)
> public class Bar {
>   @CalledByNative
>   static void doSomethingWithInner(Foo.Inner inner) {...}
> }
> 
> Notes:
> 1) Foo must be in the same package as Bar.
> 2) For classes in different packages, they should be imported as:
> import other.package.Foo;
> and this annotation should not be used.

Done.

https://codereview.chromium.org/290403002/diff/1/base/android/jni_generator/j...
File base/android/jni_generator/jni_generator_tests.py (right):

https://codereview.chromium.org/290403002/diff/1/base/android/jni_generator/j...
base/android/jni_generator/jni_generator_tests.py:1041: 
On 2014/05/19 11:54:59, bulach wrote:
> nit: just for documentation, could do with the class declaration, and also a
> "native" method:
> 
> public class Foo {
> @CalledByNative
> private static void calledByNative(Bar.Callback callback) {
> }
> ....
> ....
> private static native void nativeDoSomething(Bar.Callback callback)
> }

Done.

[qsr, 2014-05-19 12:07:49]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-05-19 12:07:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/290403002/20001

[commit-bot: I haz the power, 2014-05-19 13:54:00]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[qsr, 2014-05-19 14:26:53]

Committed patchset #2 manually as r271376 (presubmit successful).