Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: runtime/vm/intermediate_language_dbc.cc

Issue 2903993002: Remember deopt-id -> context-level mappings in var descriptors. (Closed)
Patch Set: update descriptor tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_dbc.cc
diff --git a/runtime/vm/intermediate_language_dbc.cc b/runtime/vm/intermediate_language_dbc.cc
index addebfa87701c6fb4a0b9446290c4d7266809bf7..ea9c9d8018624e0de891a80c48c28b431b037863 100644
--- a/runtime/vm/intermediate_language_dbc.cc
+++ b/runtime/vm/intermediate_language_dbc.cc
@@ -518,8 +518,8 @@ Condition StrictCompareInstr::EmitComparisonCode(FlowGraphCompiler* compiler,
if (needs_number_check() && token_pos().IsReal()) {
compiler->RecordSafepoint(locs());
- compiler->AddCurrentDescriptor(RawPcDescriptors::kRuntimeCall,
- Thread::kNoDeoptId, token_pos());
+ compiler->AddCurrentDescriptor(RawPcDescriptors::kRuntimeCall, deopt_id_,
+ token_pos());
}
return condition;
@@ -923,6 +923,8 @@ EMIT_NATIVE_CODE(StringInterpolate,
// StringInterpolateInstr::ArgumentCount() is 0. However
// internally it does a call with 1 argument which needs to
// be reflected in the lazy deoptimization environment.
+ compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(),
+ token_pos());
compiler->RecordAfterCallHelper(token_pos(), deopt_id(), kArgumentCount,
FlowGraphCompiler::kHasResult, locs());
if (compiler->is_optimizing()) {
@@ -1290,7 +1292,7 @@ EMIT_NATIVE_CODE(InstantiateTypeArguments,
void DebugStepCheckInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ DebugStep();
- compiler->AddCurrentDescriptor(stub_kind_, Thread::kNoDeoptId, token_pos());
+ compiler->AddCurrentDescriptor(stub_kind_, deopt_id_, token_pos());
}
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698