Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: runtime/vm/kernel_to_il.h

Issue 2903993002: Remember deopt-id -> context-level mappings in var descriptors. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/kernel_to_il.h
diff --git a/runtime/vm/kernel_to_il.h b/runtime/vm/kernel_to_il.h
index cc3f0069abbbac382eb681a24ee54029391fca9b..ec1773f79de62892717005828b699ae62a86146b 100644
--- a/runtime/vm/kernel_to_il.h
+++ b/runtime/vm/kernel_to_il.h
@@ -786,6 +786,7 @@ class FlowGraphBuilder : public ExpressionVisitor, public StatementVisitor {
FlowGraphBuilder(TreeNode* node,
ParsedFunction* parsed_function,
const ZoneGrowableArray<const ICData*>& ic_data_array,
+ ZoneGrowableArray<intptr_t>* context_level_array,
InlineExitCollector* exit_collector,
intptr_t osr_id,
intptr_t first_block_id = 1);
@@ -1052,14 +1053,20 @@ class FlowGraphBuilder : public ExpressionVisitor, public StatementVisitor {
ParsedFunction* parsed_function_;
intptr_t osr_id_;
const ZoneGrowableArray<const ICData*>& ic_data_array_;
+ ZoneGrowableArray<intptr_t>* context_level_array_;
InlineExitCollector* exit_collector_;
intptr_t next_block_id_;
intptr_t AllocateBlockId() { return next_block_id_++; }
intptr_t GetNextDeoptId() {
- // TODO(rmacnak): Record current scope / context level.
- return thread_->GetNextDeoptId();
+ intptr_t deopt_id = thread_->GetNextDeoptId();
+ if (context_level_array_ != NULL) {
+ intptr_t level = context_depth_;
+ context_level_array_->Add(deopt_id);
+ context_level_array_->Add(level);
+ }
+ return deopt_id;
}
intptr_t next_function_id_;

Powered by Google App Engine
This is Rietveld 408576698