Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 2903993002: Remember deopt-id -> context-level mappings in var descriptors. (Closed)
Patch Set: update descriptor tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language_dbc.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 6681 matching lines...) Expand 10 before | Expand all | Expand 10 after
6692 6692
6693 6693
6694 Condition StrictCompareInstr::EmitComparisonCode(FlowGraphCompiler* compiler, 6694 Condition StrictCompareInstr::EmitComparisonCode(FlowGraphCompiler* compiler,
6695 BranchLabels labels) { 6695 BranchLabels labels) {
6696 Location left = locs()->in(0); 6696 Location left = locs()->in(0);
6697 Location right = locs()->in(1); 6697 Location right = locs()->in(1);
6698 ASSERT(!left.IsConstant() || !right.IsConstant()); 6698 ASSERT(!left.IsConstant() || !right.IsConstant());
6699 Condition true_condition; 6699 Condition true_condition;
6700 if (left.IsConstant()) { 6700 if (left.IsConstant()) {
6701 true_condition = compiler->EmitEqualityRegConstCompare( 6701 true_condition = compiler->EmitEqualityRegConstCompare(
6702 right.reg(), left.constant(), needs_number_check(), token_pos()); 6702 right.reg(), left.constant(), needs_number_check(), token_pos(),
6703 deopt_id_);
6703 } else if (right.IsConstant()) { 6704 } else if (right.IsConstant()) {
6704 true_condition = compiler->EmitEqualityRegConstCompare( 6705 true_condition = compiler->EmitEqualityRegConstCompare(
6705 left.reg(), right.constant(), needs_number_check(), token_pos()); 6706 left.reg(), right.constant(), needs_number_check(), token_pos(),
6707 deopt_id_);
6706 } else { 6708 } else {
6707 true_condition = compiler->EmitEqualityRegRegCompare( 6709 true_condition = compiler->EmitEqualityRegRegCompare(
6708 left.reg(), right.reg(), needs_number_check(), token_pos()); 6710 left.reg(), right.reg(), needs_number_check(), token_pos(), deopt_id_);
6709 } 6711 }
6710 if (kind() != Token::kEQ_STRICT) { 6712 if (kind() != Token::kEQ_STRICT) {
6711 ASSERT(kind() == Token::kNE_STRICT); 6713 ASSERT(kind() == Token::kNE_STRICT);
6712 true_condition = NegateCondition(true_condition); 6714 true_condition = NegateCondition(true_condition);
6713 } 6715 }
6714 return true_condition; 6716 return true_condition;
6715 } 6717 }
6716 6718
6717 6719
6718 void StrictCompareInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 6720 void StrictCompareInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
6885 const StubEntry stub_entry(stub); 6887 const StubEntry stub_entry(stub);
6886 compiler->GenerateCall(token_pos(), stub_entry, RawPcDescriptors::kOther, 6888 compiler->GenerateCall(token_pos(), stub_entry, RawPcDescriptors::kOther,
6887 locs()); 6889 locs());
6888 compiler->AddStubCallTarget(stub); 6890 compiler->AddStubCallTarget(stub);
6889 __ Drop(ArgumentCount()); // Discard arguments. 6891 __ Drop(ArgumentCount()); // Discard arguments.
6890 } 6892 }
6891 6893
6892 6894
6893 void DebugStepCheckInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 6895 void DebugStepCheckInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
6894 ASSERT(!compiler->is_optimizing()); 6896 ASSERT(!compiler->is_optimizing());
6895 compiler->GenerateCall(token_pos(), *StubCode::DebugStepCheck_entry(), 6897 __ Call(*StubCode::DebugStepCheck_entry());
6896 stub_kind_, locs()); 6898 compiler->EmitCallsiteMetaData(token_pos(), deopt_id_, stub_kind_, locs());
6897 } 6899 }
6898 6900
6899 6901
6900 LocationSummary* GrowRegExpStackInstr::MakeLocationSummary(Zone* zone, 6902 LocationSummary* GrowRegExpStackInstr::MakeLocationSummary(Zone* zone,
6901 bool opt) const { 6903 bool opt) const {
6902 const intptr_t kNumInputs = 1; 6904 const intptr_t kNumInputs = 1;
6903 const intptr_t kNumTemps = 0; 6905 const intptr_t kNumTemps = 0;
6904 LocationSummary* locs = new (zone) 6906 LocationSummary* locs = new (zone)
6905 LocationSummary(zone, kNumInputs, kNumTemps, LocationSummary::kCall); 6907 LocationSummary(zone, kNumInputs, kNumTemps, LocationSummary::kCall);
6906 locs->set_in(0, Location::RegisterLocation(EAX)); 6908 locs->set_in(0, Location::RegisterLocation(EAX));
(...skipping 12 matching lines...) Expand all
6919 __ Drop(1); 6921 __ Drop(1);
6920 __ popl(result); 6922 __ popl(result);
6921 } 6923 }
6922 6924
6923 6925
6924 } // namespace dart 6926 } // namespace dart
6925 6927
6926 #undef __ 6928 #undef __
6927 6929
6928 #endif // defined TARGET_ARCH_IA32 6930 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_dbc.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698