Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: runtime/vm/dart.cc

Issue 2903993002: Remember deopt-id -> context-level mappings in var descriptors. (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/become.h" 7 #include "vm/become.h"
8 #include "vm/clustered_snapshot.h" 8 #include "vm/clustered_snapshot.h"
9 #include "vm/code_observers.h" 9 #include "vm/code_observers.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 // Different fields are included for DEBUG/RELEASE/PRODUCT. 661 // Different fields are included for DEBUG/RELEASE/PRODUCT.
662 #if defined(DEBUG) 662 #if defined(DEBUG)
663 buffer.AddString("debug"); 663 buffer.AddString("debug");
664 #elif defined(PRODUCT) 664 #elif defined(PRODUCT)
665 buffer.AddString("product"); 665 buffer.AddString("product");
666 #else 666 #else
667 buffer.AddString("release"); 667 buffer.AddString("release");
668 #endif 668 #endif
669 669
670 if (Snapshot::IncludesCode(kind)) { 670 if (Snapshot::IncludesCode(kind)) {
671 if (FLAG_support_debugger) {
672 buffer.AddString(" support-debugger");
673 }
674
671 // Checked mode affects deopt ids. 675 // Checked mode affects deopt ids.
672 #define ADD_FLAG(name, isolate_flag, flag) \ 676 #define ADD_FLAG(name, isolate_flag, flag) \
673 do { \ 677 do { \
674 const bool name = (isolate != NULL) ? isolate->name() : flag; \ 678 const bool name = (isolate != NULL) ? isolate->name() : flag; \
675 buffer.AddString(name ? (" " #name) : (" no-" #name)); \ 679 buffer.AddString(name ? (" " #name) : (" no-" #name)); \
676 } while (0); 680 } while (0);
677 ISOLATE_FLAG_LIST(ADD_FLAG); 681 ISOLATE_FLAG_LIST(ADD_FLAG);
678 #undef ADD_FLAG 682 #undef ADD_FLAG
679 683
680 // Generated code must match the host architecture and ABI. 684 // Generated code must match the host architecture and ABI.
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 return predefined_handles_->handles_.IsValidScopedHandle(address); 770 return predefined_handles_->handles_.IsValidScopedHandle(address);
767 } 771 }
768 772
769 773
770 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 774 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
771 ASSERT(predefined_handles_ != NULL); 775 ASSERT(predefined_handles_ != NULL);
772 return predefined_handles_->api_handles_.IsValidHandle(handle); 776 return predefined_handles_->api_handles_.IsValidHandle(handle);
773 } 777 }
774 778
775 } // namespace dart 779 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/debugger.h » ('j') | runtime/vm/debugger.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698