chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js - Issue 2903973002: Rich editable text implementation using spannables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 2903973002: Rich editable text implementation using spannables (Closed)

Patch Set: Address feedback. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd » ('j') | chrome/common/extensions/api/automation.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

index 5d9e6611a41b96925971727f021738a7e645b6c5..4687421cfeda4b88b31efc44b69c846667fc1554 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

@@ -769,7 +769,7 @@ Output.prototype = {

get hasSpeech() {

for (var i = 0; i < this.speechBuffer_.length; i++) {

- if (this.speechBuffer_[i].trim().length)

+ if (this.speechBuffer_[i].length)

return true;

}

return false;