Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 290393002: DevTools: more excessive dumping for jump-to-previous-position.html test (Closed)

Created:
6 years, 7 months ago by lushnikov
Modified:
6 years, 7 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: more excessive dumping for jump-to-previous-position.html test This patch, as well as r174171, adds even more excessive dumping for jump-to-previous-position.html test. The changes are expected to be reverted as the reason of failures will be detected. BUG=361588 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M LayoutTests/inspector/jump-to-previous-editing-location.html View 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/inspector/jump-to-previous-editing-location-expected.txt View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
please take a look
6 years, 7 months ago (2014-05-19 11:39:05 UTC) #1
vsevik
lgmt Please feel free to land such changes TBR.
6 years, 7 months ago (2014-05-19 13:20:17 UTC) #2
vsevik
lgtm :)
6 years, 7 months ago (2014-05-19 13:20:28 UTC) #3
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 7 months ago (2014-05-19 13:21:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/290393002/1
6 years, 7 months ago (2014-05-19 13:21:18 UTC) #5
commit-bot: I haz the power
Change committed as 174282
6 years, 7 months ago (2014-05-19 13:58:57 UTC) #6
lushnikov
6 years, 6 months ago (2014-05-30 08:47:26 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/302043003/ by lushnikov@chromium.org.

The reason for reverting is: Looks like test is not accidentally failing any
more during last week. Reverting this debugging patch.

Powered by Google App Engine
This is Rietveld 408576698