Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: content/renderer/gpu/renderer_compositor_frame_sink.h

Issue 2903853002: Make RendererCompositorFrameSink derive from ClientCompositorFrameSink (Closed)
Patch Set: Add comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/BUILD.gn ('k') | content/renderer/gpu/renderer_compositor_frame_sink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/gpu/renderer_compositor_frame_sink.h
diff --git a/content/renderer/gpu/renderer_compositor_frame_sink.h b/content/renderer/gpu/renderer_compositor_frame_sink.h
index 4de0926ff2eeb68bafc2d7f9d11d57f93f77ec9d..58a20a4aab289a3fa6521e6e850a1909ef7cf574 100644
--- a/content/renderer/gpu/renderer_compositor_frame_sink.h
+++ b/content/renderer/gpu/renderer_compositor_frame_sink.h
@@ -24,6 +24,7 @@
#include "cc/scheduler/begin_frame_source.h"
#include "cc/surfaces/local_surface_id.h"
#include "cc/surfaces/local_surface_id_allocator.h"
+#include "components/viz/client/client_compositor_frame_sink.h"
#include "content/common/render_widget_surface_properties.h"
#include "content/renderer/gpu/compositor_forwarding_message_filter.h"
#include "ipc/ipc_sync_message_filter.h"
@@ -45,10 +46,7 @@ class FrameSwapMessageQueue;
// This class can be created only on the main thread, but then becomes pinned
// to a fixed thread when BindToClient is called.
class RendererCompositorFrameSink
- : NON_EXPORTED_BASE(public cc::CompositorFrameSink),
- NON_EXPORTED_BASE(public base::NonThreadSafe),
- NON_EXPORTED_BASE(public cc::mojom::MojoCompositorFrameSinkClient),
- public cc::ExternalBeginFrameSourceClient {
+ : NON_EXPORTED_BASE(public viz::ClientCompositorFrameSink) {
public:
RendererCompositorFrameSink(
int32_t routing_id,
@@ -71,11 +69,12 @@ class RendererCompositorFrameSink
scoped_refptr<FrameSwapMessageQueue> swap_frame_message_queue);
~RendererCompositorFrameSink() override;
- // cc::CompositorFrameSink implementation.
+ // Overriden from viz::ClientCompositorFrameSink.
bool BindToClient(cc::CompositorFrameSinkClient* client) override;
void DetachFromClient() override;
void SubmitCompositorFrame(cc::CompositorFrame frame) override;
- void DidNotProduceFrame(const cc::BeginFrameAck& ack) override;
+ bool ShouldAllocateNewLocalSurfaceId(
+ const cc::CompositorFrame& frame) override;
private:
class RendererCompositorFrameSinkProxy
@@ -98,16 +97,7 @@ class RendererCompositorFrameSink
DISALLOW_COPY_AND_ASSIGN(RendererCompositorFrameSinkProxy);
};
- void OnMessageReceived(const IPC::Message& message);
-
- // cc::mojom::MojoCompositorFrameSinkClient implementation.
- void DidReceiveCompositorFrameAck(
- const cc::ReturnedResourceArray& resources) override;
- void OnBeginFrame(const cc::BeginFrameArgs& args) override;
- void ReclaimResources(const cc::ReturnedResourceArray& resources) override;
-
- // cc::ExternalBeginFrameSourceClient implementation.
- void OnNeedsBeginFrames(bool need_begin_frames) override;
+ void OnMessageReceived(const IPC::Message& message) {}
scoped_refptr<CompositorForwardingMessageFilter>
compositor_frame_sink_filter_;
@@ -116,20 +106,9 @@ class RendererCompositorFrameSink
scoped_refptr<RendererCompositorFrameSinkProxy> compositor_frame_sink_proxy_;
scoped_refptr<IPC::SyncMessageFilter> message_sender_;
scoped_refptr<FrameSwapMessageQueue> frame_swap_message_queue_;
- std::unique_ptr<cc::SyntheticBeginFrameSource> synthetic_begin_frame_source_;
- std::unique_ptr<cc::ExternalBeginFrameSource> external_begin_frame_source_;
int routing_id_;
- cc::LocalSurfaceId local_surface_id_;
- cc::LocalSurfaceIdAllocator id_allocator_;
RenderWidgetSurfaceProperties current_surface_properties_;
-
- base::ThreadChecker thread_checker_;
-
- cc::mojom::MojoCompositorFrameSinkPtr sink_;
- cc::mojom::MojoCompositorFrameSinkPtrInfo sink_info_;
- cc::mojom::MojoCompositorFrameSinkClientRequest sink_client_request_;
- mojo::Binding<cc::mojom::MojoCompositorFrameSinkClient> sink_client_binding_;
};
} // namespace content
« no previous file with comments | « content/renderer/BUILD.gn ('k') | content/renderer/gpu/renderer_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698