Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: services/ui/public/cpp/client_compositor_frame_sink.cc

Issue 2903853002: Make RendererCompositorFrameSink derive from ClientCompositorFrameSink (Closed)
Patch Set: Fixed dependency Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/public/cpp/client_compositor_frame_sink.h" 5 #include "services/ui/public/cpp/client_compositor_frame_sink.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "cc/output/begin_frame_args.h" 9 #include "cc/output/begin_frame_args.h"
10 #include "cc/output/compositor_frame.h" 10 #include "cc/output/compositor_frame.h"
11 #include "cc/output/compositor_frame_sink_client.h" 11 #include "cc/output/compositor_frame_sink_client.h"
12 12
13 namespace ui { 13 namespace ui {
14 14
15 ClientCompositorFrameSink::ClientCompositorFrameSink( 15 ClientCompositorFrameSink::ClientCompositorFrameSink(
16 scoped_refptr<cc::ContextProvider> context_provider, 16 scoped_refptr<cc::ContextProvider> context_provider,
17 scoped_refptr<cc::ContextProvider> worker_context_provider,
17 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager, 18 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
19 cc::SharedBitmapManager* shared_bitmap_manager,
20 std::unique_ptr<cc::SyntheticBeginFrameSource> synthetic_begin_frame_source,
18 cc::mojom::MojoCompositorFrameSinkPtrInfo compositor_frame_sink_info, 21 cc::mojom::MojoCompositorFrameSinkPtrInfo compositor_frame_sink_info,
19 cc::mojom::MojoCompositorFrameSinkClientRequest client_request, 22 cc::mojom::MojoCompositorFrameSinkClientRequest client_request,
20 bool enable_surface_synchronization) 23 bool enable_surface_synchronization)
21 : cc::CompositorFrameSink(std::move(context_provider), 24 : cc::CompositorFrameSink(std::move(context_provider),
22 nullptr, 25 std::move(worker_context_provider),
23 gpu_memory_buffer_manager, 26 gpu_memory_buffer_manager,
24 nullptr), 27 shared_bitmap_manager),
28 synthetic_begin_frame_source_(std::move(synthetic_begin_frame_source)),
25 compositor_frame_sink_info_(std::move(compositor_frame_sink_info)), 29 compositor_frame_sink_info_(std::move(compositor_frame_sink_info)),
26 client_request_(std::move(client_request)), 30 client_request_(std::move(client_request)),
27 enable_surface_synchronization_(enable_surface_synchronization) {} 31 client_binding_(this),
32 enable_surface_synchronization_(enable_surface_synchronization) {
33 DETACH_FROM_THREAD(thread_checker_);
34 }
35
36 ClientCompositorFrameSink::ClientCompositorFrameSink(
37 scoped_refptr<cc::VulkanContextProvider> vulkan_context_provider,
38 std::unique_ptr<cc::SyntheticBeginFrameSource> synthetic_begin_frame_source,
39 cc::mojom::MojoCompositorFrameSinkPtrInfo compositor_frame_sink_info,
40 cc::mojom::MojoCompositorFrameSinkClientRequest client_request,
41 bool enable_surface_synchronization)
42 : cc::CompositorFrameSink(std::move(vulkan_context_provider)),
43 synthetic_begin_frame_source_(std::move(synthetic_begin_frame_source)),
44 compositor_frame_sink_info_(std::move(compositor_frame_sink_info)),
45 client_request_(std::move(client_request)),
46 client_binding_(this),
47 enable_surface_synchronization_(enable_surface_synchronization) {
48 DETACH_FROM_THREAD(thread_checker_);
49 }
28 50
29 ClientCompositorFrameSink::~ClientCompositorFrameSink() {} 51 ClientCompositorFrameSink::~ClientCompositorFrameSink() {}
30 52
31 bool ClientCompositorFrameSink::BindToClient( 53 bool ClientCompositorFrameSink::BindToClient(
32 cc::CompositorFrameSinkClient* client) { 54 cc::CompositorFrameSinkClient* client) {
55 DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
56
33 if (!cc::CompositorFrameSink::BindToClient(client)) 57 if (!cc::CompositorFrameSink::BindToClient(client))
34 return false; 58 return false;
35 59
36 DCHECK(!thread_checker_);
37 thread_checker_.reset(new base::ThreadChecker());
38 compositor_frame_sink_.Bind(std::move(compositor_frame_sink_info_)); 60 compositor_frame_sink_.Bind(std::move(compositor_frame_sink_info_));
39 client_binding_.reset( 61 client_binding_.Bind(std::move(client_request_));
40 new mojo::Binding<cc::mojom::MojoCompositorFrameSinkClient>(
41 this, std::move(client_request_)));
42 62
43 begin_frame_source_ = base::MakeUnique<cc::ExternalBeginFrameSource>(this); 63 if (synthetic_begin_frame_source_) {
64 client->SetBeginFrameSource(synthetic_begin_frame_source_.get());
65 } else {
66 begin_frame_source_ = base::MakeUnique<cc::ExternalBeginFrameSource>(this);
67 client->SetBeginFrameSource(begin_frame_source_.get());
68 }
44 69
45 client->SetBeginFrameSource(begin_frame_source_.get());
46 return true; 70 return true;
47 } 71 }
48 72
49 void ClientCompositorFrameSink::DetachFromClient() { 73 void ClientCompositorFrameSink::DetachFromClient() {
74 DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
50 client_->SetBeginFrameSource(nullptr); 75 client_->SetBeginFrameSource(nullptr);
51 begin_frame_source_.reset(); 76 begin_frame_source_.reset();
52 client_binding_.reset(); 77 synthetic_begin_frame_source_.reset();
78 client_binding_.Close();
53 compositor_frame_sink_.reset(); 79 compositor_frame_sink_.reset();
54 cc::CompositorFrameSink::DetachFromClient(); 80 cc::CompositorFrameSink::DetachFromClient();
55 } 81 }
56 82
57 void ClientCompositorFrameSink::SetLocalSurfaceId( 83 void ClientCompositorFrameSink::SetLocalSurfaceId(
58 const cc::LocalSurfaceId& local_surface_id) { 84 const cc::LocalSurfaceId& local_surface_id) {
59 DCHECK(local_surface_id.is_valid()); 85 DCHECK(local_surface_id.is_valid());
60 DCHECK(enable_surface_synchronization_); 86 DCHECK(enable_surface_synchronization_);
61 local_surface_id_ = local_surface_id; 87 local_surface_id_ = local_surface_id;
62 } 88 }
63 89
64 void ClientCompositorFrameSink::SubmitCompositorFrame( 90 void ClientCompositorFrameSink::SubmitCompositorFrame(
65 cc::CompositorFrame frame) { 91 cc::CompositorFrame frame) {
66 DCHECK(thread_checker_); 92 DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
67 DCHECK(thread_checker_->CalledOnValidThread());
68 if (!compositor_frame_sink_)
69 return;
70
71 DCHECK(frame.metadata.begin_frame_ack.has_damage); 93 DCHECK(frame.metadata.begin_frame_ack.has_damage);
72 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, 94 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber,
73 frame.metadata.begin_frame_ack.sequence_number); 95 frame.metadata.begin_frame_ack.sequence_number);
74 96
75 gfx::Size frame_size = frame.render_pass_list.back()->output_rect.size(); 97 gfx::Size frame_size = frame.render_pass_list.back()->output_rect.size();
76 if (!local_surface_id_.is_valid() || 98 if (!local_surface_id_.is_valid() ||
77 frame_size != last_submitted_frame_size_) { 99 frame_size != last_submitted_frame_size_) {
78 last_submitted_frame_size_ = frame_size; 100 last_submitted_frame_size_ = frame_size;
79 if (!enable_surface_synchronization_) 101 if (!enable_surface_synchronization_)
80 local_surface_id_ = id_allocator_.GenerateId(); 102 local_surface_id_ = id_allocator_.GenerateId();
81 } 103 }
82 compositor_frame_sink_->SubmitCompositorFrame(local_surface_id_, 104 compositor_frame_sink_->SubmitCompositorFrame(local_surface_id_,
83 std::move(frame)); 105 std::move(frame));
84 } 106 }
85 107
86 void ClientCompositorFrameSink::DidNotProduceFrame( 108 void ClientCompositorFrameSink::DidNotProduceFrame(
87 const cc::BeginFrameAck& ack) { 109 const cc::BeginFrameAck& ack) {
88 DCHECK(!ack.has_damage); 110 DCHECK(!ack.has_damage);
89 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, ack.sequence_number); 111 DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
90 compositor_frame_sink_->DidNotProduceFrame(ack); 112 compositor_frame_sink_->DidNotProduceFrame(ack);
91 } 113 }
92 114
93 void ClientCompositorFrameSink::DidReceiveCompositorFrameAck( 115 void ClientCompositorFrameSink::DidReceiveCompositorFrameAck(
94 const cc::ReturnedResourceArray& resources) { 116 const cc::ReturnedResourceArray& resources) {
95 DCHECK(thread_checker_); 117 DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
96 DCHECK(thread_checker_->CalledOnValidThread());
97 if (!client_)
98 return;
99 client_->ReclaimResources(resources); 118 client_->ReclaimResources(resources);
100 client_->DidReceiveCompositorFrameAck(); 119 client_->DidReceiveCompositorFrameAck();
101 } 120 }
102 121
103 void ClientCompositorFrameSink::OnBeginFrame( 122 void ClientCompositorFrameSink::OnBeginFrame(
104 const cc::BeginFrameArgs& begin_frame_args) { 123 const cc::BeginFrameArgs& begin_frame_args) {
105 begin_frame_source_->OnBeginFrame(begin_frame_args); 124 if (begin_frame_source_)
125 begin_frame_source_->OnBeginFrame(begin_frame_args);
106 } 126 }
107 127
108 void ClientCompositorFrameSink::ReclaimResources( 128 void ClientCompositorFrameSink::ReclaimResources(
109 const cc::ReturnedResourceArray& resources) { 129 const cc::ReturnedResourceArray& resources) {
110 DCHECK(thread_checker_); 130 DCHECK_CALLED_ON_VALID_THREAD(thread_checker_);
111 DCHECK(thread_checker_->CalledOnValidThread());
112 if (!client_)
113 return;
114 client_->ReclaimResources(resources); 131 client_->ReclaimResources(resources);
115 } 132 }
116 133
117 void ClientCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) { 134 void ClientCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) {
118 compositor_frame_sink_->SetNeedsBeginFrame(needs_begin_frames); 135 compositor_frame_sink_->SetNeedsBeginFrame(needs_begin_frames);
119 } 136 }
120 137
121 } // namespace ui 138 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698