Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

Issue 2903833002: Reland: Update TextSelection for non-user initiated events
Patch Set: Suppress superfluous non-user initiated text selection events Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
index eaeffae5a70646267bcdfc50bb68846c033f52b3..42fc4605d27518589084aae9c5e584ae9337d811 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
@@ -584,7 +584,7 @@ TEST_F(RenderWidgetHostViewMacTest, GetFirstRectForCharacterRangeCaretCase) {
NSRect rect;
NSRange actual_range;
- rwhv_mac_->SelectionChanged(kDummyString, kDummyOffset, caret_range);
+ rwhv_mac_->SelectionChanged(kDummyString, kDummyOffset, caret_range, true);
params.anchor_rect = params.focus_rect = caret_rect;
params.anchor_dir = params.focus_dir = blink::kWebTextDirectionLeftToRight;
rwhv_mac_->SelectionBoundsChanged(params);
@@ -612,7 +612,7 @@ TEST_F(RenderWidgetHostViewMacTest, GetFirstRectForCharacterRangeCaretCase) {
caret_rect = gfx::Rect(20, 11, 0, 10);
caret_range = gfx::Range(1, 1);
params.anchor_rect = params.focus_rect = caret_rect;
- rwhv_mac_->SelectionChanged(kDummyString, kDummyOffset, caret_range);
+ rwhv_mac_->SelectionChanged(kDummyString, kDummyOffset, caret_range, true);
rwhv_mac_->SelectionBoundsChanged(params);
EXPECT_TRUE(rwhv_mac_->GetCachedFirstRectForCharacterRange(
caret_range.ToNSRange(),
@@ -636,7 +636,7 @@ TEST_F(RenderWidgetHostViewMacTest, GetFirstRectForCharacterRangeCaretCase) {
// No caret.
caret_range = gfx::Range(1, 2);
- rwhv_mac_->SelectionChanged(kDummyString, kDummyOffset, caret_range);
+ rwhv_mac_->SelectionChanged(kDummyString, kDummyOffset, caret_range, true);
params.anchor_rect = caret_rect;
params.focus_rect = gfx::Rect(30, 11, 0, 10);
rwhv_mac_->SelectionBoundsChanged(params);
@@ -1697,17 +1697,17 @@ TEST_F(RenderWidgetHostViewMacTest, SelectedText) {
gfx::Range range(6, 11);
// Send a valid selection for the word 'World'.
- rwhv_mac_->SelectionChanged(sample_text, 0U, range);
+ rwhv_mac_->SelectionChanged(sample_text, 0U, range, true);
EXPECT_EQ("world", selected_text());
// Make the range cover some of the text and extend more.
range.set_end(100);
- rwhv_mac_->SelectionChanged(sample_text, 0U, range);
+ rwhv_mac_->SelectionChanged(sample_text, 0U, range, true);
EXPECT_EQ("world!", selected_text());
// Finally, send an empty range. This should clear the selected text.
range.set_start(100);
- rwhv_mac_->SelectionChanged(sample_text, 0U, range);
+ rwhv_mac_->SelectionChanged(sample_text, 0U, range, true);
EXPECT_EQ("", selected_text());
}

Powered by Google App Engine
This is Rietveld 408576698