Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: third_party/WebKit/Source/core/testing/DummyModulator.cpp

Issue 2903813002: [ES6 modules] Fix context leak. ModuleScript should use TraceWrapperV8Reference to hold onto v8::Mo… (Closed)
Patch Set: testfix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/testing/DummyModulator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/testing/DummyModulator.cpp
diff --git a/third_party/WebKit/Source/core/testing/DummyModulator.cpp b/third_party/WebKit/Source/core/testing/DummyModulator.cpp
index a4bfe40b9211acd88531f6d20148fc5c854fa2a5..d5c46fdeb5fb1a3216093f5292e3c29d27d2c575 100644
--- a/third_party/WebKit/Source/core/testing/DummyModulator.cpp
+++ b/third_party/WebKit/Source/core/testing/DummyModulator.cpp
@@ -48,6 +48,11 @@ SecurityOrigin* DummyModulator::GetSecurityOrigin() {
return nullptr;
}
+ScriptState* DummyModulator::GetScriptState() {
+ NOTREACHED();
+ return nullptr;
+}
+
ScriptModuleResolver* DummyModulator::GetScriptModuleResolver() {
return resolver_.Get();
}
« no previous file with comments | « third_party/WebKit/Source/core/testing/DummyModulator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698