third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp - Issue 2903813002: [ES6 modules] Fix context leak. ModuleScript should use TraceWrapperV8Reference to hold onto v8::Mo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp

Issue 2903813002: [ES6 modules] Fix context leak. ModuleScript should use TraceWrapperV8Reference to hold onto v8::Mo… (Closed)

Patch Set: testfix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp ('k') | third_party/WebKit/Source/core/testing/DummyModulator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp

diff --git a/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp b/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp

index 2bb1f03faac36bcc73bea90a4a1be0434d288a93..d5fb8c16600ba35a4e23827a5fe2dcb8dc3af7e0 100644

--- a/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp

+++ b/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp

@@ -146,6 +146,8 @@ class ModuleTreeLinkerTestModulator final : public DummyModulator {

private:

// Implements Modulator:

+ ScriptState* GetScriptState() override { return script_state_.Get(); }

void FetchSingle(const ModuleScriptFetchRequest& request,

ModuleGraphLevel,

SingleModuleClient* client) override {