Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp

Issue 2903813002: [ES6 modules] Fix context leak. ModuleScript should use TraceWrapperV8Reference to hold onto v8::Mo… (Closed)
Patch Set: testfix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp b/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp
index 2d0ac63b908efffca81d9ff7cac24d00987fa835..b93bb84ffe4858d274f891994f21aea630b8e5a6 100644
--- a/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp
@@ -42,6 +42,8 @@ class ScriptModuleResolverImplTestModulator final : public DummyModulator {
private:
// Implements Modulator:
+ ScriptState* GetScriptState() override { return script_state_.Get(); }
+
ModuleScript* GetFetchedModuleScript(const KURL&) override;
ScriptValue GetInstantiationError(const ModuleScript* module_script) {
@@ -130,6 +132,7 @@ TEST_F(ScriptModuleResolverImplTest, RegisterResolveSuccess) {
ScriptModuleResolverImpl* resolver =
ScriptModuleResolverImpl::Create(Modulator());
V8TestingScope scope;
+ Modulator()->SetScriptState(scope.GetScriptState());
ModuleScript* referrer_module_script =
CreateReferrerModuleScript(modulator_, scope);
@@ -153,6 +156,7 @@ TEST_F(ScriptModuleResolverImplTest, ResolveInvalidModuleSpecifier) {
ScriptModuleResolverImpl* resolver =
ScriptModuleResolverImpl::Create(Modulator());
V8TestingScope scope;
+ Modulator()->SetScriptState(scope.GetScriptState());
ModuleScript* referrer_module_script =
CreateReferrerModuleScript(modulator_, scope);
@@ -174,6 +178,7 @@ TEST_F(ScriptModuleResolverImplTest, ResolveLoadFailedModule) {
ScriptModuleResolverImpl* resolver =
ScriptModuleResolverImpl::Create(Modulator());
V8TestingScope scope;
+ Modulator()->SetScriptState(scope.GetScriptState());
ModuleScript* referrer_module_script =
CreateReferrerModuleScript(modulator_, scope);

Powered by Google App Engine
This is Rietveld 408576698