third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp - Issue 2903813002: [ES6 modules] Fix context leak. ModuleScript should use TraceWrapperV8Reference to hold onto v8::Mo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

Issue 2903813002: [ES6 modules] Fix context leak. ModuleScript should use TraceWrapperV8Reference to hold onto v8::Mo… (Closed)

Patch Set: testfix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

index 349a8dd01921ea66d6433a5f527868ab5bdeb5c4..6dbdb6aca5efa23032ec8946609d3d54cea9cb6b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp

@@ -68,7 +68,7 @@ ScriptValue ScriptModule::Instantiate(ScriptState* script_state) {

DCHECK(!IsNull());

v8::Local<v8::Context> context = script_state->GetContext();

- bool success = module_->NewLocal(script_state->GetIsolate())

+ bool success = NewLocal(script_state->GetIsolate())

->Instantiate(context, &ResolveModuleCallback);

if (!success) {

DCHECK(try_catch.HasCaught());