Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/core/dom/Modulator.h

Issue 2903813002: [ES6 modules] Fix context leak. ModuleScript should use TraceWrapperV8Reference to hold onto v8::Mo… (Closed)
Patch Set: testfix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef Modulator_h 5 #ifndef Modulator_h
6 #define Modulator_h 6 #define Modulator_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/dom/AncestorList.h" 9 #include "core/dom/AncestorList.h"
10 #include "platform/bindings/ScriptWrappable.h" 10 #include "platform/bindings/ScriptWrappable.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 static void SetModulator(ScriptState*, Modulator*); 64 static void SetModulator(ScriptState*, Modulator*);
65 static void ClearModulator(ScriptState*); 65 static void ClearModulator(ScriptState*);
66 66
67 DEFINE_INLINE_VIRTUAL_TRACE() {} 67 DEFINE_INLINE_VIRTUAL_TRACE() {}
68 68
69 virtual ScriptModuleResolver* GetScriptModuleResolver() = 0; 69 virtual ScriptModuleResolver* GetScriptModuleResolver() = 0;
70 virtual WebTaskRunner* TaskRunner() = 0; 70 virtual WebTaskRunner* TaskRunner() = 0;
71 virtual ReferrerPolicy GetReferrerPolicy() = 0; 71 virtual ReferrerPolicy GetReferrerPolicy() = 0;
72 virtual SecurityOrigin* GetSecurityOrigin() = 0; 72 virtual SecurityOrigin* GetSecurityOrigin() = 0;
73 virtual ScriptState* GetScriptState() = 0;
73 74
74 // https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-module-scrip t-tree 75 // https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-module-scrip t-tree
75 virtual void FetchTree(const ModuleScriptFetchRequest&, 76 virtual void FetchTree(const ModuleScriptFetchRequest&,
76 ModuleTreeClient*) = 0; 77 ModuleTreeClient*) = 0;
77 78
78 // https://html.spec.whatwg.org/#internal-module-script-graph-fetching-procedu re 79 // https://html.spec.whatwg.org/#internal-module-script-graph-fetching-procedu re
79 virtual void FetchTreeInternal(const ModuleScriptFetchRequest&, 80 virtual void FetchTreeInternal(const ModuleScriptFetchRequest&,
80 const AncestorList&, 81 const AncestorList&,
81 ModuleGraphLevel, 82 ModuleGraphLevel,
82 ModuleTreeClient*) = 0; 83 ModuleTreeClient*) = 0;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 // if the cached entry doesn't exist. 124 // if the cached entry doesn't exist.
124 // The client can be notified either synchronously or asynchronously. 125 // The client can be notified either synchronously or asynchronously.
125 virtual void FetchNewSingleModule(const ModuleScriptFetchRequest&, 126 virtual void FetchNewSingleModule(const ModuleScriptFetchRequest&,
126 ModuleGraphLevel, 127 ModuleGraphLevel,
127 ModuleScriptLoaderClient*) = 0; 128 ModuleScriptLoaderClient*) = 0;
128 }; 129 };
129 130
130 } // namespace blink 131 } // namespace blink
131 132
132 #endif 133 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp ('k') | third_party/WebKit/Source/core/dom/ModulatorImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698