Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7429)

Unified Diff: chrome/test/data/extensions/api_test/native_bindings/extension/background.js

Issue 2903803004: [Extensions Bindings] Fix content settings validation (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/native_bindings/extension/background.js
diff --git a/chrome/test/data/extensions/api_test/native_bindings/extension/background.js b/chrome/test/data/extensions/api_test/native_bindings/extension/background.js
index d4935ebff54f6ea77ce56c97f02e507323548d81..516cf9b00144ec88a61f53db717abf2de2ec0186 100644
--- a/chrome/test/data/extensions/api_test/native_bindings/extension/background.js
+++ b/chrome/test/data/extensions/api_test/native_bindings/extension/background.js
@@ -296,21 +296,13 @@ var tests = [
// The fullscreen setting is deprecated.
var fullscreen = chrome.contentSettings.fullscreen;
- caught = false;
- try {
- // Trying to set the fullscreen setting to anything but 'allow' should
- // fail.
- fullscreen.set({primaryPattern: pattern, setting: 'block'});
- } catch (e) {
- caught = true;
- }
- chrome.test.assertTrue(caught);
-
var deprecatedSettingTest = new Promise(function(resolve, reject) {
fullscreen.get({primaryUrl: url}, (details) => {
chrome.test.assertTrue(!!details);
chrome.test.assertEq('allow', details.setting);
- fullscreen.set({primaryPattern: pattern, setting: 'allow'}, () => {
+ // Trying to set the fullscreen setting to anything but 'allow' should
+ // silently fail.
+ fullscreen.set({primaryPattern: pattern, setting: 'block'}, () => {
fullscreen.get({primaryUrl: url}, (details) => {
chrome.test.assertTrue(!!details);
chrome.test.assertEq('allow', details.setting);
« no previous file with comments | « chrome/test/data/extensions/api_test/content_settings/standard/test.js ('k') | extensions/renderer/content_setting.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698