Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: chrome/test/data/extensions/api_test/native_bindings/extension/background.js

Issue 2903803004: [Extensions Bindings] Fix content settings validation (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 if (!chrome || !chrome.test) 5 if (!chrome || !chrome.test)
6 throw new Error('chrome.test is undefined'); 6 throw new Error('chrome.test is undefined');
7 7
8 var portNumber; 8 var portNumber;
9 9
10 // This is a good end-to-end test for two reasons. The first is obvious - it 10 // This is a good end-to-end test for two reasons. The first is obvious - it
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 chrome.test.assertTrue(!!details); 289 chrome.test.assertTrue(!!details);
290 chrome.test.assertEq('block', details.setting); 290 chrome.test.assertEq('block', details.setting);
291 resolve(); 291 resolve();
292 }); 292 });
293 }); 293 });
294 }); 294 });
295 }); 295 });
296 296
297 // The fullscreen setting is deprecated. 297 // The fullscreen setting is deprecated.
298 var fullscreen = chrome.contentSettings.fullscreen; 298 var fullscreen = chrome.contentSettings.fullscreen;
299 caught = false;
300 try {
301 // Trying to set the fullscreen setting to anything but 'allow' should
302 // fail.
303 fullscreen.set({primaryPattern: pattern, setting: 'block'});
304 } catch (e) {
305 caught = true;
306 }
307 chrome.test.assertTrue(caught);
308
309 var deprecatedSettingTest = new Promise(function(resolve, reject) { 299 var deprecatedSettingTest = new Promise(function(resolve, reject) {
310 fullscreen.get({primaryUrl: url}, (details) => { 300 fullscreen.get({primaryUrl: url}, (details) => {
311 chrome.test.assertTrue(!!details); 301 chrome.test.assertTrue(!!details);
312 chrome.test.assertEq('allow', details.setting); 302 chrome.test.assertEq('allow', details.setting);
313 fullscreen.set({primaryPattern: pattern, setting: 'allow'}, () => { 303 // Trying to set the fullscreen setting to anything but 'allow' should
304 // silently fail.
305 fullscreen.set({primaryPattern: pattern, setting: 'block'}, () => {
314 fullscreen.get({primaryUrl: url}, (details) => { 306 fullscreen.get({primaryUrl: url}, (details) => {
315 chrome.test.assertTrue(!!details); 307 chrome.test.assertTrue(!!details);
316 chrome.test.assertEq('allow', details.setting); 308 chrome.test.assertEq('allow', details.setting);
317 resolve(); 309 resolve();
318 }); 310 });
319 }); 311 });
320 }); 312 });
321 }); 313 });
322 314
323 Promise.all([normalSettingTest, deprecatedSettingTest]).then(() => { 315 Promise.all([normalSettingTest, deprecatedSettingTest]).then(() => {
324 chrome.test.succeed(); 316 chrome.test.succeed();
325 }); 317 });
326 }, 318 },
327 ]; 319 ];
328 320
329 chrome.test.getConfig(config => { 321 chrome.test.getConfig(config => {
330 chrome.test.assertTrue(!!config, 'config does not exist'); 322 chrome.test.assertTrue(!!config, 'config does not exist');
331 chrome.test.assertTrue(!!config.testServer, 'testServer does not exist'); 323 chrome.test.assertTrue(!!config.testServer, 'testServer does not exist');
332 portNumber = config.testServer.port; 324 portNumber = config.testServer.port;
333 chrome.test.runTests(tests); 325 chrome.test.runTests(tests);
334 }); 326 });
OLDNEW
« no previous file with comments | « chrome/test/data/extensions/api_test/content_settings/standard/test.js ('k') | extensions/renderer/content_setting.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698