Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2903753002: Use failedAt in more places (js_emitter) (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
index af06d0f2bd4f7bb0c1d574e9a60f39b5ebbb6d19..7215e2b9c0a87786e534d72f6171b222bf75e3ac 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
@@ -227,8 +227,11 @@ class ProgramBuilder {
ClassEntity superclass = _elementEnvironment.getSuperClass(cls);
if (superclass != null) {
c.setSuperclass(_classes[superclass]);
- assert(invariant(cls, c.superclass != null,
- message: "No Class for has been created for superclass "
+ assert(
+ c.superclass != null,
+ failedAt(
+ cls,
+ "No Class for has been created for superclass "
"${superclass} of $c."));
}
if (c is MixinApplication) {
@@ -693,8 +696,8 @@ class ProgramBuilder {
_jsInteropAnalysis);
void visitMember(ClassElement enclosing, MemberElement member) {
- assert(invariant(element, member.isDeclaration));
- assert(invariant(element, element == enclosing));
+ assert(member.isDeclaration, failedAt(element));
+ assert(element == enclosing, failedAt(element));
if (Elements.isNonAbstractInstanceMember(member)) {
// TODO(herhut): Remove once _buildMethod can no longer return null.
@@ -904,9 +907,9 @@ class ProgramBuilder {
}
if (canTearOff) {
- assert(invariant(element, !element.isGenerativeConstructor));
- assert(invariant(element, !element.isGenerativeConstructorBody));
- assert(invariant(element, !element.isConstructor));
+ assert(!element.isGenerativeConstructor, failedAt(element));
+ assert(!element.isGenerativeConstructorBody, failedAt(element));
+ assert(!element.isConstructor, failedAt(element));
}
js.Name callName = null;
@@ -1045,7 +1048,7 @@ class ProgramBuilder {
bool needsGetter,
bool needsSetter,
bool needsCheckedSetter) {
- assert(invariant(field, field.isDeclaration));
+ assert(field.isDeclaration, failedAt(field));
int getterFlags = 0;
if (needsGetter) {

Powered by Google App Engine
This is Rietveld 408576698