Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2903753002: Use failedAt in more places (js_emitter) (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -28 lines) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 4 chunks +11 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 7 months ago (2017-05-23 23:53:01 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-24 00:03:12 UTC) #3
sra1
3 years, 7 months ago (2017-05-24 00:19:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2126af08b36c29983f937ddeabacd68af37884b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698