Porting SecureSocket to use BoringSSL on OSX

runtime/bin/secure_socket.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file

[zra, 2017/06/02 22:56:24]

I'd just delete this file, and move its contents to secure_socket_filter.h.
Include both secure_socket_filter.h and security_context.h where this was
included before, like in bin/io_service.cc.

[bkonyi, 2017/06/05 20:25:51]

Completely missed this comment. Will update in next patch.

 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_BIN_SECURE_SOCKET_H_
 #define RUNTIME_BIN_SECURE_SOCKET_H_
 
 #if defined(DART_IO_DISABLED) || defined(DART_IO_SECURE_SOCKET_DISABLED)
 #error "secure_socket.h can only be included on builds with SSL enabled"
 #endif
 
 #include "platform/globals.h"
-#if defined(HOST_OS_ANDROID) || defined(HOST_OS_LINUX) ||                      \
-    defined(HOST_OS_WINDOWS) || defined(HOST_OS_FUCHSIA)
-#include "bin/secure_socket_boringssl.h"
-#elif defined(HOST_OS_MACOS)
-#if HOST_OS_IOS
-#include "bin/secure_socket_ios.h"
-#else  // HOST_OS_IOS
-#include "bin/secure_socket_macos.h"
-#endif  // HOST_OS_IOS
-#else
-#error Unknown target os.
-#endif
+
+#include "bin/secure_socket_filter.h"
+#include "bin/security_context.h"
+
+const bool SSL_LOG_STATUS = false;

[zra, 2017/06/02 22:56:24]

Probably move these to secure_socket_utils.h

[bkonyi, 2017/06/05 20:25:51]

Done.

+const bool SSL_LOG_DATA = false;
+const bool SSL_LOG_CERTS = false;
 
 #endif  // RUNTIME_BIN_SECURE_SOCKET_H_