Tighten HAS_PRIVATE to own properties

src/macros.py

Index: src/macros.py
diff --git a/src/macros.py b/src/macros.py
index 3eb906f74d6eb9024aa16705adc4b664c477f138..9b256cb7b961f977c584023c0760c5f90a7113e5 100644
--- a/src/macros.py
+++ b/src/macros.py
@@ -166,10 +166,12 @@ macro TO_OBJECT_INLINE(arg) = (IS_SPEC_OBJECT(%IS_VAR(arg)) ? arg : ToObject(arg
 macro JSON_NUMBER_TO_STRING(arg) = ((%_IsSmi(%IS_VAR(arg)) || arg - arg == 0) ? %_NumberToString(arg) : "null");
 
 # Private names.
+# GET_PRIVATE should only be used if the property is known to exists on obj
+# itself (it should really use %GetOwnProperty, but that would be way slower).
 macro GLOBAL_PRIVATE(name) = (%CreateGlobalPrivateSymbol(name));
 macro NEW_PRIVATE(name) = (%CreatePrivateSymbol(name));
 macro IS_PRIVATE(sym) = (%SymbolIsPrivate(sym));
-macro HAS_PRIVATE(obj, sym) = (sym in obj);
+macro HAS_PRIVATE(obj, sym) = (%HasOwnProperty(obj, sym));

[Michael Starzinger, 2014/05/19 21:21:02]

OK, maybe I am confused here, but IMHO the macro HAS_PRIVATE is not used
anywhere in the codebase. Which in turn explains why it is no problem that the
%HasOwnProperty runtime does not exists. I think I need more context here.

[rossberg, 2014/05/20 06:57:19]

Oops, how embarrassing, that should be HasLocalProperty, of course. (It will
come in useful for one of Arv's in-flight CLs.)

It's unfortunate that it's not possible to write tests for macros.py...

 macro GET_PRIVATE(obj, sym) = (obj[sym]);
 macro SET_PRIVATE(obj, sym, val) = (obj[sym] = val);
 macro DELETE_PRIVATE(obj, sym) = (delete obj[sym]);