Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 290373002: Tighten HAS_PRIVATE to own properties (Closed)

Created:
6 years, 7 months ago by rossberg
Modified:
6 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, arv (Not doing code reviews)
Visibility:
Public.

Description

Tighten HAS_PRIVATE to own properties R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21379

Patch Set 1 #

Patch Set 2 : Eps #

Total comments: 2

Patch Set 3 : Own vs Local #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/macros.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rossberg
6 years, 7 months ago (2014-05-19 11:05:05 UTC) #1
Michael Starzinger
I am confused! Can you provide context? https://codereview.chromium.org/290373002/diff/20001/src/macros.py File src/macros.py (right): https://codereview.chromium.org/290373002/diff/20001/src/macros.py#newcode174 src/macros.py:174: macro HAS_PRIVATE(obj, ...
6 years, 7 months ago (2014-05-19 21:21:01 UTC) #2
rossberg
https://codereview.chromium.org/290373002/diff/20001/src/macros.py File src/macros.py (right): https://codereview.chromium.org/290373002/diff/20001/src/macros.py#newcode174 src/macros.py:174: macro HAS_PRIVATE(obj, sym) = (%HasOwnProperty(obj, sym)); On 2014/05/19 21:21:02, ...
6 years, 7 months ago (2014-05-20 06:57:19 UTC) #3
Michael Starzinger
LGTM.
6 years, 7 months ago (2014-05-20 09:12:24 UTC) #4
rossberg
6 years, 7 months ago (2014-05-20 09:13:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r21379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698