update pub to latest

update pub to latest

BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/6b1c7e94079f11b6782bbd947b765520115f8b1d

[jakemac, 2017-05-23 22:26:18]

jakemac@google.com changed reviewers:
+ jacobr@google.com

[Jacob, 2017-05-23 22:26:44]

lgtm

[jakemac, 2017-05-23 22:27:17]

Description was changed from

==========
update pub to latest

BUG=
==========

to

==========
update pub to latest

BUG=
R=jacobr@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6b1c7e94079f11b6782bbd947b765520115f8b1d
==========

[jakemac, 2017-05-23 22:27:19]

Committed patchset #1 (id:1) manually as
6b1c7e94079f11b6782bbd947b765520115f8b1d (presubmit successful).

[nweiz, 2017-05-25 18:33:54]

nweiz@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2017-05-25 18:33:55]

A few things:

1) When pub is pulled into the SDK, you need to manually make sure the packages
it depends on are up to date. In this case it's partially my fault that this
isn't clear, since I didn't catch the need for an updated dependency in
https://github.com/dart-lang/pub/pull/1616. This is breaking downstream users.

2) When pub is pulled into the SDK, you need to add CHANGELOG entries for all
user-visible changes. It looks like none of the changes in pub since 69be47e
have been documented.

3) Please make sure Bob or I are at least CC'ed on pub CLs, even if they're in
the SDK repo. We're familiar with the process, and can help catch issues like
this before they break users.

[jakemac, 2017-05-25 19:21:26]

> 1) When pub is pulled into the SDK, you need to manually make sure the
packages
> it depends on are up to date. In this case it's partially my fault that this
> isn't clear, since I didn't catch the need for an updated dependency in
> https://github.com/dart-lang/pub/pull/1616. This is breaking downstream users.

I was aware of this, I just didn't catch that I needed to bump the version at
all in this case :(.

> 2) When pub is pulled into the SDK, you need to add CHANGELOG entries for all
> user-visible changes. It looks like none of the changes in pub since 69be47e
> have been documented.

Good call, I can send a followup cl to edit the CHANGELOG.

> 3) Please make sure Bob or I are at least CC'ed on pub CLs, even if they're in
> the SDK repo. We're familiar with the process, and can help catch issues like
> this before they break users.

Will do in the future.