Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.h

Issue 2903703003: Use wrapper tracing for worklets. (Closed)
Patch Set: Separating in two CLs Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.h b/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.h
index 6e2ddabb8016712600a30d21a2a146eb599ee6b6..26e9f55c6df75cd269c0fd2947a845fba969b282 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.h
+++ b/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessorDefinition.h
@@ -6,7 +6,8 @@
#define AudioWorkletProcessorDefinition_h
#include "modules/ModulesExport.h"
-#include "platform/bindings/ScopedPersistent.h"
+#include "platform/bindings/ScriptWrappable.h"
+#include "platform/bindings/TraceWrapperV8Reference.h"
#include "platform/heap/Handle.h"
#include "platform/wtf/text/WTFString.h"
#include "v8/include/v8.h"
@@ -21,7 +22,8 @@ namespace blink {
// This is constructed and destroyed on a worker thread, and all methods also
// must be called on the worker thread.
class MODULES_EXPORT AudioWorkletProcessorDefinition final
- : public GarbageCollectedFinalized<AudioWorkletProcessorDefinition> {
+ : public GarbageCollectedFinalized<AudioWorkletProcessorDefinition>,
+ public TraceWrapperBase {
public:
static AudioWorkletProcessorDefinition* Create(
v8::Isolate*,
@@ -36,6 +38,7 @@ class MODULES_EXPORT AudioWorkletProcessorDefinition final
v8::Local<v8::Function> ProcessLocal(v8::Isolate*);
DEFINE_INLINE_TRACE(){};
+ DECLARE_TRACE_WRAPPERS();
private:
AudioWorkletProcessorDefinition(v8::Isolate*,
@@ -47,8 +50,8 @@ class MODULES_EXPORT AudioWorkletProcessorDefinition final
// The definition is per global scope. The active instance of
// |AudioProcessorWorklet| should be passed into these to perform JS function.
- ScopedPersistent<v8::Function> constructor_;
- ScopedPersistent<v8::Function> process_;
+ TraceWrapperV8Reference<v8::Function> constructor_;
+ TraceWrapperV8Reference<v8::Function> process_;
// TODO(hongchan): A container for AudioParamDescriptor objects.
// ScopedPersistent<v8::Array> m_parameterDescriptors;

Powered by Google App Engine
This is Rietveld 408576698