Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: third_party/WebKit/Source/modules/compositorworker/Animator.h

Issue 2903703003: Use wrapper tracing for worklets. (Closed)
Patch Set: Separating in two CLs Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/compositorworker/Animator.h
diff --git a/third_party/WebKit/Source/modules/compositorworker/Animator.h b/third_party/WebKit/Source/modules/compositorworker/Animator.h
index b46b4f777d969377ed157dac187f6c58b5fff5bb..c1b88120725af5f66c60b51999bcd299ee3351cd 100644
--- a/third_party/WebKit/Source/modules/compositorworker/Animator.h
+++ b/third_party/WebKit/Source/modules/compositorworker/Animator.h
@@ -5,7 +5,9 @@
#ifndef Animator_h
#define Animator_h
-#include "platform/bindings/ScopedPersistent.h"
+#include "platform/bindings/ScriptWrappable.h"
+#include "platform/bindings/TraceWrapperMember.h"
+#include "platform/bindings/TraceWrapperV8Reference.h"
#include "platform/heap/Handle.h"
#include "v8/include/v8.h"
@@ -13,19 +15,19 @@ namespace blink {
class AnimatorDefinition;
-class Animator final : public GarbageCollectedFinalized<Animator> {
+class Animator final : public GarbageCollectedFinalized<Animator>,
+ public TraceWrapperBase {
public:
Animator(v8::Isolate*, AnimatorDefinition*, v8::Local<v8::Object> instance);
~Animator();
DECLARE_TRACE();
+ DECLARE_TRACE_WRAPPERS();
private:
// This object keeps the definition object, and animator instance alive.
- // It needs to be destroyed to break a reference cycle between it and the
- // AnimationWorkletGlobalScope. The reference cycle is broken at
- // |AnimationWorkletGlobalScope::Dispose()|.
- Member<AnimatorDefinition> definition_;
- ScopedPersistent<v8::Object> instance_;
+ // It participates in wrapper tracing as it holds onto V8 wrappers.
+ TraceWrapperMember<AnimatorDefinition> definition_;
+ TraceWrapperV8Reference<v8::Object> instance_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698