third_party/WebKit/Source/modules/compositorworker/Animator.cpp - Issue 2903703003: Use wrapper tracing for worklets.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/compositorworker/Animator.cpp

Issue 2903703003: Use wrapper tracing for worklets. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.cpp ('K') | « third_party/WebKit/Source/modules/compositorworker/Animator.h ('k') | third_party/WebKit/Source/modules/compositorworker/AnimatorDefinition.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "modules/compositorworker/Animator.h"	5 #include "modules/compositorworker/Animator.h"

6	6

7 #include "modules/compositorworker/AnimatorDefinition.h"	7 #include "modules/compositorworker/AnimatorDefinition.h"

8 #include "platform/bindings/ScriptState.h"	8 #include "platform/bindings/ScriptState.h"

9	9

10 namespace blink {	10 namespace blink {

11	11

12 Animator::Animator(v8::Isolate* isolate,	12 Animator::Animator(v8::Isolate* isolate,

13 AnimatorDefinition* definition,	13 AnimatorDefinition* definition,

14 v8::Local<v8::Object> instance)	14 v8::Local<v8::Object> instance)

15 : definition_(definition), instance_(isolate, instance) {}	15 : definition_(this, definition), instance_(isolate, this, instance) {}

16	16

17 Animator::~Animator() {}	17 Animator::~Animator() {}

18	18

19 DEFINE_TRACE(Animator) {	19 DEFINE_TRACE_WRAPPERS(Animator) {
Michael Lippautz 2017/05/24 14:42:43 Why don't we need to trace the definition for Oilp Why don't we need to trace the definition for Oilpan? majidvp 2017/05/25 20:16:57 Fixed. We actually do. Show quoted text On 2017/05/24 14:42:43, Michael Lippautz wrote: > Why don't we need to trace the definition for Oilpan? Fixed. We actually do.
20 visitor->Trace(definition_);	20 visitor->TraceWrappers(definition_);

	21 visitor->TraceWrappers(instance_.Cast<v8::Value>());

21 }	22 }

22	23

23 } // namespace blink	24 } // namespace blink

OLD	NEW