Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/testing/dart/utils.dart

Issue 2903703002: Tighten types in test.dart even more. (Closed)
Patch Set: Play nicer with strong mode. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_suite.dart ('k') | tools/testing/dart/vendored_pkg/args/args.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/utils.dart
diff --git a/tools/testing/dart/utils.dart b/tools/testing/dart/utils.dart
index b80f4bcd0504339634ef61eb566c93648ef7d6c9..a6d008e6993757ea76ae6535cfcfd400265b0b15 100644
--- a/tools/testing/dart/utils.dart
+++ b/tools/testing/dart/utils.dart
@@ -180,8 +180,8 @@ String decodeUtf8(List<int> bytes) {
class Locations {
static String getBrowserLocation(
- String browserName, Map<String, String> globalConfiguration) {
- var location = globalConfiguration[browserName];
+ String browserName, Map<String, dynamic> globalConfiguration) {
+ var location = globalConfiguration[browserName] as String;
if (location != null && location != '') {
return location;
}
« no previous file with comments | « tools/testing/dart/test_suite.dart ('k') | tools/testing/dart/vendored_pkg/args/args.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698