Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/testing/dart/html_test.dart

Issue 2903703002: Tighten types in test.dart even more. (Closed)
Patch Set: Merge branch 'master' into 2-more-types Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/html_test.dart
diff --git a/tools/testing/dart/html_test.dart b/tools/testing/dart/html_test.dart
index dfa555ffb03449c70e808337c26a7a7ba58a1c1f..eb3f9427a4125a20fb1c458a8f5fb8ea49de2a9f 100644
--- a/tools/testing/dart/html_test.dart
+++ b/tools/testing/dart/html_test.dart
@@ -38,8 +38,10 @@ HtmlTestInformation getInformation(String filename) {
" Should have {'scripts':[...], 'expectedMessages':[...]}");
return null;
}
- return new HtmlTestInformation(new Path(filename),
- annotation['expectedMessages'], annotation['scripts']);
+ return new HtmlTestInformation(
+ new Path(filename),
+ annotation['expectedMessages'] as List<String>,
Siggi Cherem (dart-lang) 2017/05/30 20:48:39 It seems this could fail in strong mode: the under
Bob Nystrom 2017/05/30 21:01:46 Ah, yes. Good catch. Fixed.
+ annotation['scripts'] as List<String>);
}
String getContents(HtmlTestInformation info, bool compileToJS) {

Powered by Google App Engine
This is Rietveld 408576698