Tighten types in test.dart even more.

tools/testing/dart/reset_safari.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Helper program for killing and resetting all Safari settings to a known
 /// state that works well for testing dart2js output in Safari.
 ///
 /// Warning: this will delete all your Safari settings and bookmarks.
 library testing.reset_safari;
 
 import 'dart:async' show Future, Timer;
 
-import 'dart:io' show Directory, File, Platform, Process, ProcessResult;
+import 'dart:io' show Directory, File, Platform, Process;
 
 const String defaultSafariBundleLocation = "/Applications/Safari.app/";
 
 const String relativeSafariLocation = "Contents/MacOS/Safari";
 
 const String lsofLocation = "/usr/sbin/lsof";
 
 const String killLocation = "/bin/kill";
 
 const String pkillLocation = "/usr/bin/pkill";
@@ skipping 80 matching lines @@
   if (force && testOnly) {
     throw new ArgumentError("[force] and [testOnly] can't both be true.");
   }
   if (force) return "-KILL";
   if (testOnly) return "-0";
   return defaultSignal;
 }
 
 Future<int> kill(List<String> pids,
     {bool force: false, bool testOnly: false}) async {
-  List<String> arguments = <String>[
-    signalArgument("-TERM", force: force, testOnly: testOnly)
-  ]..addAll(pids);
-  ProcessResult result = await Process.run(killLocation, arguments);
+  var arguments = [signalArgument("-TERM", force: force, testOnly: testOnly)]
+    ..addAll(pids);
+  var result = await Process.run(killLocation, arguments);
   return result.exitCode;
 }
 
 Future<int> pkill(String pattern,
     {bool force: false, bool testOnly: false}) async {
-  List<String> arguments = <String>[
+  var arguments = [
     signalArgument("-HUP", force: force, testOnly: testOnly),
     pattern
   ];
-  ProcessResult result = await Process.run(pkillLocation, arguments);
+  var result = await Process.run(pkillLocation, arguments);
   return result.exitCode;
 }
 
 Uri validatedBundleName(Uri bundle) {
   if (bundle == null) return Uri.base.resolve(defaultSafariBundleLocation);
   if (!bundle.path.endsWith("/")) {
     throw new ArgumentError("Bundle ('$bundle') must end with a slash ('/').");
   }
   return bundle;
 }
 
 Future<Null> killSafari({Uri bundle}) async {
   bundle = validatedBundleName(bundle);
-  Uri safariBinary = bundle.resolve(relativeSafariLocation);
-  ProcessResult result =
+  var safariBinary = bundle.resolve(relativeSafariLocation);
+  var result =
       await Process.run(lsofLocation, ["-t", safariBinary.toFilePath()]);
   if (result.exitCode == 0) {
-    String stdout = result.stdout;
-    List<String> pids = new List<String>.from(
-        stdout.split("\n").where((String line) => !line.isEmpty));
-    Timer timer = new Timer(const Duration(seconds: 10), () {
+    var stdout = result.stdout as String;
+    var pids =
+        stdout.split("\n").where((String line) => !line.isEmpty).toList();
+    var timer = new Timer(const Duration(seconds: 10), () {
       print("Kill -9 Safari $pids");
       kill(pids, force: true);
     });
-    int exitCode = await kill(pids);
+    var exitCode = await kill(pids);
     while (exitCode == 0) {
       await pollDelay;
       print("Polling Safari $pids");
       exitCode = await kill(pids, testOnly: true);
     }
     timer.cancel();
   }
-  Timer timer = new Timer(const Duration(seconds: 10), () {
+  var timer = new Timer(const Duration(seconds: 10), () {
     print("Kill -9 $safari");
     pkill(safari, force: true);
   });
-  int exitCode = await pkill(safari);
+  var exitCode = await pkill(safari);
   while (exitCode == 0) {
     await pollDelay;
     print("Polling $safari");
     exitCode = await pkill(safari, testOnly: true);
   }
   timer.cancel();
 }
 
 Future<Null> deleteIfExists(Uri uri) async {
-  Directory directory = new Directory.fromUri(uri);
+  var directory = new Directory.fromUri(uri);
   if (await directory.exists()) {
     print("Deleting directory '$uri'.");
     await directory.delete(recursive: true);
   } else {
-    File file = new File.fromUri(uri);
+    var file = new File.fromUri(uri);
     if (await file.exists()) {
       print("Deleting file '$uri'.");
       await file.delete();
     } else {
       print("File '$uri' not found.");
     }
   }
 }
 
 Future<Null> resetSafariSettings() async {
-  String home = Platform.environment["HOME"];
+  var home = Platform.environment["HOME"];
   if (!home.endsWith("/")) {
     home = "$home/";
   }
-  Uri homeDirectory = Uri.base.resolve(home);
+  var homeDirectory = Uri.base.resolve(home);
   for (String setting in safariSettings) {
     await deleteIfExists(homeDirectory.resolve(setting));
   }
-  ProcessResult result = await Process
+  var result = await Process
       .run(defaultsLocation, <String>["write", safari, knownSafariPreference]);
   if (result.exitCode != 0) {
     throw "Unable to reset Safari settings: ${result.stdout}${result.stderr}";
   }
 }
 
 Future<Null> killAndResetSafari({Uri bundle}) async {
   bundle = validatedBundleName(bundle);
   await killSafari(bundle: bundle);
   await resetSafariSettings();
 }
 
 Future<Null> main() async {
   await killAndResetSafari();
 }