Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: tools/testing/dart/drt_updater.dart

Issue 2903703002: Tighten types in test.dart even more. (Closed)
Patch Set: Play nicer with strong mode. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/html_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // TODO(antonm): rename to something like test_runner_updater. 5 // TODO(antonm): rename to something like test_runner_updater.
6 6
7 library drt_updater; 7 library drt_updater;
8 8
9 import "dart:async"; 9 import "dart:async";
10 import "dart:io"; 10 import "dart:io";
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 exit(1); 64 exit(1);
65 } 65 }
66 for (var callback in onUpdated) callback(); 66 for (var callback in onUpdated) callback();
67 } 67 }
68 } 68 }
69 69
70 _DartiumUpdater _contentShellUpdater; 70 _DartiumUpdater _contentShellUpdater;
71 _DartiumUpdater _dartiumUpdater; 71 _DartiumUpdater _dartiumUpdater;
72 72
73 _DartiumUpdater runtimeUpdater(Map configuration) { 73 _DartiumUpdater runtimeUpdater(Map configuration) {
74 String runtime = configuration['runtime']; 74 var runtime = configuration['runtime'] as String;
75 if (runtime == 'drt' && configuration['drt'] == '') { 75 if (runtime == 'drt' && configuration['drt'] == '') {
76 // Download the default content shell from Google Storage. 76 // Download the default content shell from Google Storage.
77 if (_contentShellUpdater == null) { 77 if (_contentShellUpdater == null) {
78 _contentShellUpdater = 78 _contentShellUpdater =
79 new _DartiumUpdater('Content Shell', 'tools/get_archive.py', 'drt'); 79 new _DartiumUpdater('Content Shell', 'tools/get_archive.py', 'drt');
80 } 80 }
81 return _contentShellUpdater; 81 return _contentShellUpdater;
82 } else if (runtime == 'dartium' && configuration['dartium'] == '') { 82 } else if (runtime == 'dartium' && configuration['dartium'] == '') {
83 // Download the default Dartium from Google Storage. 83 // Download the default Dartium from Google Storage.
84 if (_dartiumUpdater == null) { 84 if (_dartiumUpdater == null) {
85 _dartiumUpdater = new _DartiumUpdater( 85 _dartiumUpdater = new _DartiumUpdater(
86 'Dartium Chrome', 'tools/get_archive.py', 'dartium'); 86 'Dartium Chrome', 'tools/get_archive.py', 'dartium');
87 } 87 }
88 return _dartiumUpdater; 88 return _dartiumUpdater;
89 } else { 89 } else {
90 return null; 90 return null;
91 } 91 }
92 } 92 }
OLDNEW
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/html_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698